Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add two calculation and application fields as notes (hl-1550) #3549

Merged
merged 2 commits into from
Nov 25, 2024
Merged

feat: add two calculation and application fields as notes (hl-1550) #3549

merged 2 commits into from
Nov 25, 2024
+110 −11

Conversation

sirtawast
Copy link
Collaborator

@sirtawast sirtawast commented Nov 19, 2024 •
edited
Loading

Description ✨

Override default GET / list() endpoint and add rejected application comment and calculation comment as notes.

  • Include manual calculation comment into notes (calculation.override_manual_benefit_amount_comment)
  • Include accepted/rejected comment into notes (log_entry with transition to rejected or accepted)
  • Send handler language preference to backend so that correct django translations are loaded
    • force Finnish for now

image

@sirtawast sirtawast changed the title Hl 1550 feat: add other models' properties as notes (hl-1550) Nov 19, 2024
@sirtawast sirtawast changed the title feat: add other models' properties as notes (hl-1550) feat: add calculation and application models' properties as notes (hl-1550) Nov 19, 2024
@sirtawast sirtawast changed the title feat: add calculation and application models' properties as notes (hl-1550) feat: add calculation and application model fields as notes (hl-1550) Nov 19, 2024
@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr3549.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3549.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr3549.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr3549.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr3549.dev.hel.ninja 😆🎉🎉🎉

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 19, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
41 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.8% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 19, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
58 New issues
8 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.1% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 19, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
11 New issues
3 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 19, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
34 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3549.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr3549.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr3549.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr3549.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr3549.dev.hel.ninja 😆🎉🎉🎉

@sirtawast sirtawast changed the title feat: add calculation and application model fields as notes (hl-1550) feat: add two calculation and application model fields as notes (hl-1550) Nov 22, 2024
@sirtawast sirtawast changed the title feat: add two calculation and application model fields as notes (hl-1550) feat: add two calculation and application fields as notes (hl-1550) Nov 22, 2024
@JanneJuhola JanneJuhola merged commit 823e5cd into main Nov 25, 2024
64 checks passed
@JanneJuhola JanneJuhola deleted the hl-1550 branch November 25, 2024 12:02
This was referenced Nov 25, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikuke rikuke rikuke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sirtawast @terovirtanen @rikuke @JanneJuhola