Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/unit connections new types and tag field #296

Merged
merged 18 commits into from
Aug 4, 2023

Conversation

juuso-j
Copy link

@juuso-j juuso-j commented Jul 21, 2023

Unit connections new types and tag field

Trello #444


Breakdown:

Files changed

  1. services/models/unit_connection.py
    • Add PRICE_TYPE, SUBGROUP_TYPE and OPENING_HOUR_OBJECT types. Add field tags, changed name max_length to 2100.
  2. services/migrations/0096_alter_unitconnection_section_type.py
    • Add PRICE_TYPE
  3. services/migrations/0097_update_unitconnection_names.py
    • Change name max_length to 2100
  4. services/migrations/0098_alter_unitconnection_section_type.py
    • Add SUBGROUP_TYPE
  5. services/migrations/0099_unitconnection_tags.py
    • Add field tags
  6. services/migrations/0100_alter_unitconnection_section_type.py
    • Add section type

@juuso-j juuso-j added the enhancement New feature or request label Jul 21, 2023
@juuso-j juuso-j self-assigned this Jul 21, 2023
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage: 95.58% and project coverage change: +0.29 🎉

Comparison is base (5aebd57) 66.76% compared to head (afe893a) 67.05%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #296      +/-   ##
===========================================
+ Coverage    66.76%   67.05%   +0.29%     
===========================================
  Files          221      222       +1     
  Lines        12899    12964      +65     
  Branches      1654     1658       +4     
===========================================
+ Hits          8612     8693      +81     
+ Misses        3911     3895      -16     
  Partials       376      376              
Impacted Files Coverage Δ
services/search/api.py 69.23% <83.33%> (+0.68%) ⬆️
services/models/search_rule.py 90.90% <90.90%> (ø)
services/models/__init__.py 100.00% <100.00%> (ø)
services/models/unit_connection.py 100.00% <100.00%> (ø)
services/search/tests/conftest.py 100.00% <100.00%> (ø)
services/search/tests/test_api.py 100.00% <100.00%> (ø)
services/search/utils.py 67.70% <100.00%> (+1.77%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@juuso-j juuso-j requested a review from ezkat August 4, 2023 06:15
@juuso-j juuso-j merged commit c7ed645 into develop Aug 4, 2023
5 checks passed
@juuso-j juuso-j mentioned this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants