Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update project settings #297

Merged
merged 19 commits into from
Aug 4, 2023
Merged

Conversation

juuso-j
Copy link

@juuso-j juuso-j commented Jul 21, 2023

Update project settings

Trello #445


Breakdown:

Files changed

  1. config_dev.env.example
    • Add log level examples
  2. requirements.in
  3. requirements.txt
    • Replace Raven with Sentry
  4. smbackend/settings.py
    • Read log levels from env, replace Raven wtih Sentry. Read secret_key from env.

@juuso-j juuso-j added enhancement New feature or request dependencies Pull requests that update a dependency file labels Jul 21, 2023
@juuso-j juuso-j self-assigned this Jul 21, 2023
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage: 96.25% and project coverage change: +0.26 🎉

Comparison is base (5aebd57) 66.76% compared to head (1f37f74) 67.03%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #297      +/-   ##
===========================================
+ Coverage    66.76%   67.03%   +0.26%     
===========================================
  Files          221      222       +1     
  Lines        12899    12953      +54     
  Branches      1654     1655       +1     
===========================================
+ Hits          8612     8683      +71     
+ Misses        3911     3896      -15     
+ Partials       376      374       -2     
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
services/search/api.py 67.69% <83.33%> (-0.86%) ⬇️
services/models/search_rule.py 90.90% <90.90%> (ø)
services/models/__init__.py 100.00% <100.00%> (ø)
services/search/tests/conftest.py 100.00% <100.00%> (ø)
services/search/tests/test_api.py 100.00% <100.00%> (ø)
services/search/utils.py 67.70% <100.00%> (+1.77%) ⬆️
smbackend/settings.py 88.28% <100.00%> (+3.20%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@juuso-j juuso-j requested a review from ezkat August 4, 2023 06:15
@juuso-j juuso-j merged commit 5701c53 into develop Aug 4, 2023
5 checks passed
@juuso-j juuso-j mentioned this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants