Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/environment data app #315

Merged
merged 70 commits into from
Oct 30, 2023
Merged

Feature/environment data app #315

merged 70 commits into from
Oct 30, 2023

Conversation

juuso-j
Copy link

@juuso-j juuso-j commented Oct 23, 2023

Environment data APP

APP for storing environment history data

Trello #491


Breakdown:

API

  1. environment_data/api/constants.py
    • API constants
  2. environment_data/api/serializers.py
    • API serializers
  3. environment_data/api/urls.py
    • API urls
  4. environment_data/api/utils.py
    • Utility functions for the API
  5. environment_data/api/views.py
    • API views

Importers/management commands

  1. environment_data/management/commands/air_quality_utils.py
    • Utility function for air quality
  2. environment_data/management/commands/constants.py
    • Importer constants
  3. environment_data/management/commands/delete_all_environment_data.py
    • Management command to delete all environment data
  4. environment_data/management/commands/import_environment_data.py
    • Management command to import environment data
  5. environment_data/management/commands/utils.py
    • Importer utility functions
  6. environment_data/management/commands/weather_observation_constants.py
    • Weather observation constants
  7. environment_data/management/commands/weather_observation_utils.py
    • Weather observation utility function
  8. environment_data/management/commands/air_quality_constants.py
    • Air quality constants

Models

  1. environment_data/models.py
    • Model for the APP
  2. environment_data/translation.py
    • Model translations
  3. environment_data/migrations/0001_initial.py
    • Initial migrations

Test

  1. environment_data/tests/conftest.py
    • Test fixtures
  2. environment_data/tests/test_api.py
    • API tests
  3. environment_data/tests/test_importer.py
    • Importer tests

Other

  1. environment_data/README.md
    • Add README
  2. environment_data/admin.py
    • Add basic admin
  3. environment_data/apps.py
    • APP config
  4. environment_data/constants.py
    • Common constants for the APP
  5. environment_data/tasks.py
    • Celery tasks
  6. smbackend/settings.py
    • Add APP, logging and doc endpoints
  7. smbackend/urls.py
    • Add environment data API urls

@juuso-j juuso-j added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 23, 2023
@juuso-j juuso-j requested a review from ezkat October 23, 2023 05:51
@juuso-j juuso-j self-assigned this Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Attention: 254 lines in your changes are missing coverage. Please review.

Comparison is base (bcc68d8) 67.28% compared to head (fcc3a82) 68.77%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #315      +/-   ##
===========================================
+ Coverage    67.28%   68.77%   +1.49%     
===========================================
  Files          214      235      +21     
  Lines        12967    14400    +1433     
  Branches      1647     1776     +129     
===========================================
+ Hits          8725     9904    +1179     
- Misses        3883     4120     +237     
- Partials       359      376      +17     
Files Coverage Δ
environment_data/api/constants.py 100.00% <100.00%> (ø)
environment_data/api/urls.py 100.00% <100.00%> (ø)
environment_data/apps.py 100.00% <100.00%> (ø)
environment_data/constants.py 100.00% <100.00%> (ø)
..._data/management/commands/air_quality_constants.py 100.00% <100.00%> (ø)
environment_data/management/commands/constants.py 100.00% <100.00%> (ø)
...nagement/commands/weather_observation_constants.py 100.00% <100.00%> (ø)
environment_data/tests/conftest.py 100.00% <100.00%> (ø)
environment_data/tests/test_api.py 100.00% <100.00%> (ø)
environment_data/tests/test_importer.py 100.00% <100.00%> (ø)
... and 13 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juuso-j juuso-j merged commit ad0e7d9 into develop Oct 30, 2023
5 checks passed
@juuso-j juuso-j mentioned this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants