Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/exceptional situations app #338

Merged
merged 38 commits into from
Apr 2, 2024

Conversation

juuso-j
Copy link

@juuso-j juuso-j commented Mar 27, 2024

App for storing, serving and importing exceptional situations

Trello #524


Breakdown:

API

  1. exceptional_situations/api/serializers.py
    • Add serializers for the models
  2. exceptional_situations/api/urls.py
  3. smbackend/urls.py
    • Add urls for the API
  4. exceptional_situations/api/views.py
    • Add model ViewSets and filters

Management commands

  1. exceptional_situations/management/commands/delete_inactive_situations.py
    • Deletes inactive situations and related rows
  2. exceptional_situations/management/commands/import_traffic_situations.py
    • Import road works and traffic announcements in Southwest Finland

Models

  1. exceptional_situations/migrations/0001_initial.py
  2. exceptional_situations/migrations/init.py
  3. exceptional_situations/models.py
    • Add models for storing exceptional situations
  4. exceptional_situations/translation.py
    • Define fields for multilingual support

Tests

  1. exceptional_situations/tests/conftest.py
    • Add test fixtures
  2. exceptional_situations/tests/test_api.py
    • Add API tests
  3. exceptional_situations/tests/test_delete_inactive_situations.py
    • Test delete inactive situations management command
  4. exceptional_situations/tests/test_models.py
    • Add model tests

Other

  1. exceptional_situations/README.md
    • Readme for the APP
  2. exceptional_situations/init.py
  3. exceptional_situations/admin.py
    • Basic Admin for the models
  4. exceptional_situations/apps.py
    • Add APP config
  5. smbackend/settings.py
    • Add APP to INSTALLED_APP, logging configuration

@juuso-j juuso-j added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 27, 2024
@juuso-j juuso-j requested a review from ezkat March 27, 2024 12:55
@juuso-j juuso-j self-assigned this Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 95.60976% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 68.82%. Comparing base (c63fd90) to head (8f36228).
Report is 17 commits behind head on develop.

Files Patch % Lines
exceptional_situations/tasks.py 0.00% 8 Missing ⚠️
exceptional_situations/api/views.py 92.30% 4 Missing ⚠️
exceptional_situations/models.py 94.20% 3 Missing and 1 partial ⚠️
exceptional_situations/admin.py 93.75% 1 Missing ⚠️
.../management/commands/delete_inactive_situations.py 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #338      +/-   ##
===========================================
+ Coverage    68.13%   68.82%   +0.69%     
===========================================
  Files          238      251      +13     
  Lines        15284    15707     +423     
  Branches      1894     1914      +20     
===========================================
+ Hits         10414    10811     +397     
- Misses        4483     4507      +24     
- Partials       387      389       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juuso-j juuso-j merged commit 30aced5 into develop Apr 2, 2024
5 checks passed
@juuso-j juuso-j mentioned this pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants