Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/import parking garages #352

Merged
merged 9 commits into from
May 21, 2024
Merged

Conversation

juuso-j
Copy link

@juuso-j juuso-j commented May 3, 2024

Parking garage importer

Trello #587


Breakdown:

Importer

  1. mobility_data/constants.py
    • Add content type to data sources.
  2. mobility_data/data/parkkihallit.csv
    • Initial static source data.
  3. mobility_data/importers/charging_stations.py
    • Use get_full_csv_file_name from utils.
  4. mobility_data/importers/data/content_types.yml
    • Add content type for parking garages.
  5. mobility_data/importers/parking_garages.py
    • Importer for parking garages.
  6. mobility_data/importers/utils.py
    • Add get_full_csv_file_name and split_string_at_digit functions.
  7. mobility_data/management/commands/import_parking_garages.py
    • Management command for importing parking garages.

Tests

  1. mobility_data/tests/conftest.py
    • Add street Juhana Herttuan puistokatu
  2. mobility_data/tests/data/parkkihallit_fixtures.csv
    • Add parking garages fixture data.
  3. mobility_data/tests/test_import_charging_stations.py
    • Mock get_full_csv_file_name.
  4. mobility_data/tests/test_import_parking_garages.py
    • Test parking garages importer

Other

  1. mobility_data/README.md
    • Info about importing parking garages.
  2. mobility_data/tasks.py
    • Add task that imports parking garages

@juuso-j juuso-j added documentation Improvements or additions to documentation enhancement New feature or request labels May 3, 2024
@juuso-j juuso-j requested a review from ezkat May 3, 2024 06:32
@juuso-j juuso-j self-assigned this May 3, 2024
@juuso-j juuso-j merged commit bb8975f into develop May 21, 2024
3 checks passed
@juuso-j juuso-j mentioned this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants