Datateam datafreshness #339
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gnating user and pass
… error in civis import311 datetime values
…o a PR--hope this is how it works!
ian-r-rose
reviewed
Aug 11, 2020
There was a problem hiding this comment.
@prestinomills I see there are some KYC scripts in here, is that intended?
|
|
||
| lahub_user = os.environ["LAHUB_ACC_USERNAME"] | ||
| lahub_pass = os.environ["LAHUB_ACC_PASSWORD"] | ||
| socrata_token = 'LJ60SFL7ZqoC4IWosLhEmJV2a' |
There was a problem hiding this comment.
May be worth also putting this in an environment variable, if it should be considered sensitive.
|
|
||
| def prep_permit_data(file,token,user,pas): | ||
| client = Socrata("data.lacity.org", token, username=user, password=pas) | ||
| df = pd.DataFrame(client.get('n9nq-vewq', limit=10000000)) |
There was a problem hiding this comment.
Are we guaranteed that by limiting to ten million rows, we get all requests from the last six months? If we do get back ten million rows, might it crash the instance we are running?
It may be worth executing a SoQL query to get a more targeted subset, rather than reading them all into memory. Unless you already tried that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to add the data freshness report (by creating a new branch because I wasn't sure whether I'd be able to use/update the datafreshness branch)...Hunter had mentioned making a pull request to revisit the snags found in the data freshness script.
Best,