Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CU-86dt261uc - Adjust NWM to use ETH RPC when running TESTNET (Temp fix while we migrate to BitQuery v2) #42

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

raulduartep
Copy link
Contributor

No description provided.

@melanke
Copy link
Contributor

melanke commented Mar 25, 2024

packages/bs-ethereum/src/BSEthereum.ts Show resolved Hide resolved
import { BitqueryBDSEthereum } from '../BitqueryBDSEthereum'
import { DEFAULT_URL_BY_NETWORK_TYPE } from '../constants'

const bitqueryBDSEthereum = new BitqueryBDSEthereum(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a good practice to use process.env directly in the code. Consider using a config file or a configuration service to manage environment variables.

@melanke melanke merged commit 06cb6dc into main Mar 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants