Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CU-86drpncat - Wrong tuple type hint is compiled on Neo3-boa #1232

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

meevee98
Copy link
Contributor

@meevee98 meevee98 commented Apr 8, 2024

Summary or solution description
Changed how the compiler handles tuple annotations to have the expected Python behavior.
Before it was handled the same way as list annotations, making tuple[int], tuple[int, int], tuple[int, ...], tuple[int, int, int] and similar to be handled as the same.

Also added support to ellipsis (... annotation) to be able to handle tuples without specific length

@meevee98 meevee98 self-assigned this Apr 8, 2024
@melanke
Copy link
Contributor

melanke commented Apr 8, 2024

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 91.926% (-0.003%) from 91.929%
when pulling 63b77ec on CU-86drpncat
into 1a1f407 on development.

@luc10921 luc10921 merged commit 9d1b679 into development Apr 9, 2024
4 checks passed
@luc10921 luc10921 deleted the CU-86drpncat branch April 9, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants