Hebrew Language #26
Hebrew Language #26
Conversation
| Map<Character, Integer> enMap = new HashMap<Character, Integer>(); | ||
| enMap.put('.', 1); enMap.put(',', 1); enMap.put('!', 1); enMap.put('?', 1); | ||
| enMap.put('-', 1); enMap.put('"', 1); enMap.put('\'', 1); enMap.put('@', 1); | ||
| enMap.put('#', 1); enMap.put('$', 1); enMap.put('%', 1); enMap.put('&', 1); | ||
| enMap.put('*', 1); enMap.put('(', 1); enMap.put(')', 1); enMap.put(':', 1); | ||
| enMap.put(';', 1); enMap.put('/', 1); enMap.put('+', 1); enMap.put('=', 1); | ||
| enMap.put('<', 1); enMap.put('>', 1); enMap.put('^', 1); enMap.put('_', 1); | ||
| enMap.put('~', 1); enMap.put('1', 1); enMap.put('ד', 2); enMap.put('ה', 2); | ||
| enMap.put('ו', 2); enMap.put('2', 2); enMap.put('א', 3); enMap.put('ב', 3); | ||
| enMap.put('ג', 3); enMap.put('3', 3); enMap.put('מ', 4); enMap.put('ם', 4); | ||
| enMap.put('נ', 4); enMap.put('ן', 4); enMap.put('4', 4); enMap.put('י', 5); | ||
| enMap.put('כ', 5); enMap.put('ך', 5); enMap.put('ל', 5); enMap.put('5', 5); | ||
| enMap.put('ז', 6); enMap.put('ח', 6); enMap.put('ט', 6); enMap.put('6', 6); | ||
| enMap.put('ר', 7); enMap.put('ש', 7); enMap.put('ת', 7); enMap.put('7', 7); | ||
| enMap.put('צ', 8); enMap.put('ץ', 8); enMap.put('ק', 8); enMap.put('8', 8); | ||
| enMap.put('ס', 9); enMap.put('ע', 9); enMap.put('פ', 9); enMap.put('ף', 9); | ||
| enMap.put('9', 9); enMap.put('+', 0); enMap.put('0', 0); |
There was a problem hiding this comment.
This should probably be heMap, not enMap.
Using enMap will overwrite the english map (I suspect it will also cause a compile error since it's already defined)
| // add extra characters for German and French maps. | ||
| enMap.put('€', 1); enMap.put('*', 7); // German chars | ||
| enMap.put('æ', 1); enMap.put('ם', 4); enMap.put('!', 8); enMap.put('&', 6); // French chars | ||
| enMap.put('ן', 4); enMap.put('ץ', 8); // Italian chars | ||
| Map<Character, Integer> endefritmap = Collections.unmodifiableMap(enMap); | ||
| CHARTABLE.add(0, endefritmap); |
There was a problem hiding this comment.
You likely don't need these lines for the hebrew map.
|
Hello, Thanks for your efforts. I've marked it in the file. Additionally, as per https://github.com/Clam-/TraditionalT9/wiki/New-Language-support Thanks again. |
|
I was thinking of switching from Russian to Hebrew
I replaced Russian manipulations is that good?
בתאריך יום ד׳, 12 באוג׳ 2020 ב-3:35 מאת Clam- <notifications@github.com
>:
… Hello,
Thanks for your efforts.
However it looks like you are overwriting the English character map?
I've marked it in the file.
Additionally, as per
https://github.com/Clam-/TraditionalT9/wiki/New-Language-support
We need a new entry in langhelper for the hebew icon, and a dictionary
(although I suppose you don't need a dictionary if you just want single
character entry.
And I think you may have missed some other items from this checklist.
Thanks again.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/Clam-/TraditionalT9/pull/26#issuecomment-672396883>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APEF22TFEOT3BUGMA5VGD5LSAHPWJANCNFSM4P3XJYHQ>
.
|
|
עדכנתי את הקובץ כמו שאמרת
בתאריך יום ד׳, 12 באוג׳ 2020 ב-4:18 מאת יוסף דיב <wspdyb@gmail.com>:
… I was thinking of switching from Russian to Hebrew
I replaced Russian manipulations is that good?
בתאריך יום ד׳, 12 באוג׳ 2020 ב-3:35 מאת Clam- <
***@***.***>:
> Hello,
>
> Thanks for your efforts.
> However it looks like you are overwriting the English character map?
>
> I've marked it in the file.
>
> Additionally, as per
> https://github.com/Clam-/TraditionalT9/wiki/New-Language-support
> We need a new entry in langhelper for the hebew icon, and a dictionary
> (although I suppose you don't need a dictionary if you just want single
> character entry.
> And I think you may have missed some other items from this checklist.
>
> Thanks again.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/Clam-/TraditionalT9/pull/26#issuecomment-672396883>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/APEF22TFEOT3BUGMA5VGD5LSAHPWJANCNFSM4P3XJYHQ>
> .
>
|
|
|
|
Language Values and Strange Translation I will do later, I just want a clone of the Java, !! |
|
@wspdyb i have created a great hebrew T9 keyboard for more info pls contact me |
|
@wspdyb I took a look at your fork, and it seems you have many branch, each with a different change. Have you given up on advancing this? |
|
Please see #38 . |
|
free? |
|
Pull request is here, how can it not be free? |
I edited the file to add a Hebrew language.