Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

A bit more feature overhaul and bug fixes #31

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

vladkorotnev
Copy link
Contributor

@vladkorotnev vladkorotnev commented Feb 22, 2021

Please review this in detail as I've changed the database so maybe it has breaking changes.

Changed things:

  • Add proper description to the "Spacebar on 0 key" option (used to have same subtitle as keymap option)
  • Don't add Ukrainian letters to Russian keyplane when unpacking pregenerated dictionary
  • Allow disabling scroll animation of the candidate list (just personal preference, any GUI animations make it feel slow for me :P)
  • More intelligent frequency updating
  • Add some Internet-sourced Ru/En corpus from LuminosoInsight data
  • Add some basis for further per-model quirks support and fix softkeys on SH-01J
  • Make the "Add Word" dialog type in the actual word on confirming, and assign max priority to it in the DB

Detailed explanation of "Intelligent frequency updating":

Old algorithm used to increment frequency each time the word is chosen. If the frequency went past 10000 then all frequencies for that key sequence will be divided by 10000. That would cause problems if you have a VERY popular word and some less popular words on the same sequence — if you type in the VERY popular one 10000+ times, order of all others will mess up.

New algorithm brings the chosen word to the top, if it's not the topmost, then does nothing. This also helps to deal with a preheated dictionary having a bunch of nonsense with a bigger frequency than what you wanted to type.

I've used this now for a few minutes and it's as comfortable as my old Nokias were (or how I remember them) :-)

@sspanak
Copy link
Contributor

sspanak commented Jun 11, 2022

Hey, @vladkorotnev , did you make any configuration changes to make the project build on newer versions of Android Studio or you are just using an old version?

Your changes look ok and I want to use them as a base for adding a new language, but I am still struggling at the start...

@vladkorotnev
Copy link
Contributor Author

I don’t think I did, even if anything it was something Android Studio suggested on its own. And I was using the latest at the time.

@sspanak
Copy link
Contributor

sspanak commented Jun 11, 2022

I see. Well, it seems some things have changed in the meantime, so I guess I have to figure them out on my own. Thanks anyway!

@joddsus
Copy link

joddsus commented Jun 11, 2022 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants