Feature/full app #1

ClaudiaRojasSoto · 2023-10-18T20:42:54Z

Description

This pull request introduces the following changes as part of the feature implementation of my budget tracker app

General Requirements

No linter errors present.
Correct Gitflow process followed.
Professional documentation of the work.

Ruby Requirements

Followed best practices for Ruby.

Design

Implemented the design guidelines, including colors, typography, and layout.
Gave appropriate credit to the original design by Gregoire Vella as required by the Creative Commons license.

Interactions

Implemented the splash screen, sign-up, log-in, and other interactions as specified in the requirements.

Testing

Unit and integration tests created and executed for all critical components.

Technical Requirements

Used Postgres as the database.
Integrated Devise for authentication.
Validated user input for security.
Used [mention the view template engine used].

Deployment

The project is deployed and accessible online.
Deploy

Database Schema

The database schema reflects the required structure as outlined in the ERD diagram.

Demo Video

Demo Video

Please, review my project and give me feedback to improve it.

Thank you for your review!

Greetings!
@ClaudiaRojasSoto

… some regex

…he permitted parameters on the configuration for full name

…ral configurations

Munsa1

Hi @ClaudiaRojasSoto,

Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation but you are almost there!

Suggested changes

Check the comments under the review.

📹 Video Presentation🎞️

Great video presentation, you were clear and audible. You also highlighted code you found interesting, kudos!

You can use as many of my suggestions as you want. If there is anything you would like to skip - feel free to do that. However, I strongly recommend you to take them into account as they can make your code better._

You can also consider:
N/A

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Munsa1 · 2023-10-18T22:23:51Z

app/views/devise/registrations/new.html.erb

+<div class="container form-login">
+ <%= form_for(resource, as: resource_name, url: registration_path(resource_name), html: { class: 'login-form' }) do |f| %>
+ <div class="header-container blue">
+ <a href="<%= root_path %>" class="back-arrow">←</a>
+ <h2 id="login-title">REGISTER</h2>
+ <%= f.submit "Sign up", class: "btn-login blue" %>
+ </div>
+
+ <% if resource.errors.any? %>
+ <div id="error_explanation">
+ <h2><%= pluralize(resource.errors.count, "error") %> prohibited this user from being saved:</h2>
+ <ul>
+ <% resource.errors.full_messages.each do |message| %>
+ <li><%= message %></li>
+ <% end %>
+ </ul>
+ </div>
+ <% end %>
+
+ <div class="field">
+ <%= f.text_field :full_name, autofocus: true, autocomplete: "name", class: "input", placeholder: "Full Name" %>
+ </div>


Kindly ensure your design matches the given design in terms of layout for the sign-up and Login page.

Your design

Given design

Make sure your items align as is in the given design

Make sure your input field s match the given design

Done, Thank you @Munsa1

Munsa1 · 2023-10-18T22:27:35Z

app/views/home/start.html.erb

+<div class="container start">
+ <h1 class="start-title">WELCOME!!</h1>
+ <div class="button-container">
+ <a class="start-button" href="<%= categories_path %>">START</a>
+ </div>
+</div>


Upon successful sign up the user should be directed to the Categories page, not the welcome page. Kindly fix this

After sign in

Expected view

Done @Munsa1 Thank you

Munsa1 · 2023-10-18T23:00:35Z

app/controllers/categories_controller.rb

+ def index
+ @categories = current_user.categories
+ # @total_purchases = current_user.purchases.pluck(:amount).sum
+ # @total_purchases = current_user.purchases.joins(:categories).pluck(:amount).sum
+ @total_purchases = current_user.purchases.includes(:categories).pluck(:amount).sum


Kindly remove commented lines of code for a cleaner codebase

Done @Munsa1 Thank you.

Munsa1 · 2023-10-18T23:10:35Z

app/views/purchases/index.html.erb

+<div class="blue">
+ <div class="container-sm">
+ <div class="header-container blue d-flex justify-between align-end">
+ <a href="<%= categories_path %>" class="back-button"><i class="fa-solid fa-arrow-left" style="color: #ffffff;"></i></a>
+ <h1 class="category-title"><%= @category.name %></h1>
+ <a href="<%= categories_path %>" class="btn-login blue"><i class="fa-solid fa-magnifying-glass" style="color: #ffffff;"></i></a>
+ </div>
+ <div class="d-flex justify-between gap-10">
+ <div class="w-1-3">
+
+ </div>
+
+ <div class="small-div w-1-3 d-flex flex-column align-center justify-end most-recent-container ">
+ <p class="text">Most recent</p>
+ <p class="dot">•</p>
+ </div>
+ <div class="small-div w-1-3 d-flex flex-column align-center justify-end most-ancient-container">
+ <p class="text">Most ancient</p>
+ <p class="dot">•</p>
+ </div>
+ </div>
+ </div>
+</div>


Kindly fix your design in terms of font weight, and color for the categories text. Notice that the text for the price is bold and the color is #434b54.

Your design

Given design

Done @Munsa1 Thank you

…tegories controller and change the routes to have categories as a home

tresorsawasawa

STATUS: APPROVE ✔️ ✔️ 🍾

Hi @ClaudiaRojasSoto
Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉 👏 👏 💯

To highlight 🍾

All design issues are fixed ✔️
All pages are displayed correctly ✔️

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please ping me @tresorsawasawa when you comment so I can receive the notification or use slack with the same name.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

tresorsawasawa · 2023-10-19T04:09:28Z

app/views/purchases/index.html.erb

+ <h1 class="category-title"><%= @category.name %></h1>
+ <a href="<%= categories_path %>" class="btn-login blue"><i class="fa-solid fa-magnifying-glass" style="color: #ffffff;"></i></a>
+ </div>
+ <div class="d-flex justify-between gap-10">
+ <div class="w-1-3">
+
+ </div>
+
+ <div class="small-div w-1-3 d-flex flex-column align-center justify-end most-recent-container ">
+ <p class="text">Most recent</p>
+ <p class="dot">•</p>
+ </div>
+ <div class="small-div w-1-3 d-flex flex-column align-center justify-end most-ancient-container">
+ <p class="text">Most ancient</p>
+ <p class="dot">•</p>
+ </div>
+ </div>
+ </div>
+</div>
+
+<div class="container-sm">
+ <div class="total-amount d-flex justify-between align-center">
+ <h2>Total Amount:</h2>
+ <p>$<%= @category.category_total %></p>
+ </div>
+</div>
+
+<hr>
+
+<div class="container-sm">
+ <h2>Transactions:</h2>


[ OPTIONAL ] To correctly match the organization of the page and make it be significantly, I think it would be better if you replace the Transactions title where you put of the <%= @category.name %> and vice versa. The title of the will be at the top then the <%= @category.name %> at his expected place.

Done!, thank you @tresorsawasawa

tresorsawasawa · 2023-10-19T04:13:40Z

app/views/purchases/index.html.erb

+ <a href="<%= categories_path %>" class="back-button"><i class="fa-solid fa-arrow-left" style="color: #ffffff;"></i></a>
+ <h1 class="category-title"><%= @category.name %></h1>
+ <a href="<%= categories_path %>" class="btn-login blue"><i class="fa-solid fa-magnifying-glass" style="color: #ffffff;"></i></a>


[ OPTIONAL ] For CSS best practices, I think it would be better if you don't use inline styling like you did in some views files

ClaudiaRojasSoto added 30 commits September 20, 2023 17:34

Create the files with 'rails new...' by commnad line

0ba3df5

Add the devise gem and all the necesaries gems to make the test

64512bd

Upload the file with command line after add the gems

59b81e9

Add the migrations

4d727eb

Upload the schema with the new migrations

ab8dd95

Add the specs folders with adding the rails-spec gem

7e91e1b

Add devise for users and craetes all the folders and files with it

e203107

Add the empty helper for home

ae0f1ba

Add the Controller for the home

9c5b1f9

Add the views for the welcome views

a715496

Add the views for the authentification

4971afa

Creates the user model including the validation for the full name and…

f779cb1

… some regex

Creates the model for categories with their relations and validations

eca035a

Creates the model for purchases with their relations and validations

690de51

Creates the model for the intermedial table with their relations

60afe6e

Creates empty the user controller

e909e3d

Creates the controller for categories

9453d31

Creates the purchases controller

30256d8

Creates the controller for the intermedial table

fc7fba6

Creates the file for adding styles to the home page

c1ae04a

Craetes the file to adding styles to the sign in page

15187e7

Add universal styles with variables

d0b642a

Creates an empty action only in case

e1adb9a

Add the befor action for devise, the new path for after sign in and t…

d726d3b

…he permitted parameters on the configuration for full name

By terminal using rails new command creates the test, routes and gene…

9241672

…ral configurations

Add a new migration to add user id to categories

1ac2b17

Add a new migration to change the name of author id to user id

9b7cf85

Add views to categories folder

6cbc571

Upload the user model with the new table name

d2b398c

Upload the names

203e95c

ClaudiaRojasSoto added 25 commits October 17, 2023 20:45

Fix linter errors

50a53c1

Fix linter errors

23b71aa

Add icons at public images folder

8d589b7

Add te property overflow hidden to the body

7800c62

Add the path to the arrow

0d79d83

Add the path to the arrow

8707b6a

Add classes to give styles at the page

ffbb61a

Create the purchase new test

64895be

Upload test

5b8fd3f

Fix n plus one problems and update the testing files with this changes

19637ae

Fix linter errors

62d609b

dd the icons to the purchases from categories

7be52ad

Modify the categories selector

eb130f9

Includes puts for depurating

27f9c39

Delete the property overflow hidden

f7ebb66

Upload styles

fec7f2a

Upload the new purchase test with the changes on the view

55ee6ce

Ass the video link to the readme

9381506

Configuration for render and deploy

f274437

Add plataform x86 for linux to gem lock

781fed2

Upload readme file

e29a219

establishing to true the enviroment

63449cc

Puting assets compile on true

6f5b460

Testing css only on application css

0051900

Add to layout the css files

0c4935a

Munsa1 suggested changes Oct 18, 2023

View reviewed changes

Solved the styles corrected on the review, deleted the comments on ca…

5fd91bf

…tegories controller and change the routes to have categories as a home

tresorsawasawa approved these changes Oct 19, 2023

View reviewed changes

Change the position of the category name and transactions

0290b6a

ClaudiaRojasSoto merged commit bd41a21 into develop Oct 19, 2023
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/full app #1

Feature/full app #1

ClaudiaRojasSoto commented Oct 18, 2023

Munsa1 left a comment •

edited

Loading

Munsa1 Oct 18, 2023 •

edited by ClaudiaRojasSoto

Loading

ClaudiaRojasSoto Oct 19, 2023

Munsa1 Oct 18, 2023 •

edited by ClaudiaRojasSoto

Loading

ClaudiaRojasSoto Oct 19, 2023

Munsa1 Oct 18, 2023 •

edited by ClaudiaRojasSoto

Loading

ClaudiaRojasSoto Oct 19, 2023

Munsa1 Oct 18, 2023 •

edited by ClaudiaRojasSoto

Loading

ClaudiaRojasSoto Oct 19, 2023

tresorsawasawa left a comment

tresorsawasawa Oct 19, 2023

ClaudiaRojasSoto Oct 19, 2023

tresorsawasawa Oct 19, 2023

Feature/full app #1

Feature/full app #1

Conversation

ClaudiaRojasSoto commented Oct 18, 2023

Description

General Requirements

Ruby Requirements

Design

Interactions

Testing

Technical Requirements

Deployment

Database Schema

Demo Video

Thank you for your review!

Munsa1 left a comment • edited Loading

Choose a reason for hiding this comment

Suggested changes

📹 Video Presentation🎞️

Munsa1 Oct 18, 2023 • edited by ClaudiaRojasSoto Loading

Choose a reason for hiding this comment

ClaudiaRojasSoto Oct 19, 2023

Choose a reason for hiding this comment

Munsa1 Oct 18, 2023 • edited by ClaudiaRojasSoto Loading

Choose a reason for hiding this comment

ClaudiaRojasSoto Oct 19, 2023

Choose a reason for hiding this comment

Munsa1 Oct 18, 2023 • edited by ClaudiaRojasSoto Loading

Choose a reason for hiding this comment

ClaudiaRojasSoto Oct 19, 2023

Choose a reason for hiding this comment

Munsa1 Oct 18, 2023 • edited by ClaudiaRojasSoto Loading

Choose a reason for hiding this comment

ClaudiaRojasSoto Oct 19, 2023

Choose a reason for hiding this comment

tresorsawasawa left a comment

Choose a reason for hiding this comment

STATUS: APPROVE ✔️ ✔️ 🍾

To highlight 🍾

Optional suggestions

tresorsawasawa Oct 19, 2023

Choose a reason for hiding this comment

ClaudiaRojasSoto Oct 19, 2023

Choose a reason for hiding this comment

tresorsawasawa Oct 19, 2023

Choose a reason for hiding this comment

Munsa1 left a comment •

edited

Loading

Munsa1 Oct 18, 2023 •

edited by ClaudiaRojasSoto

Loading

Munsa1 Oct 18, 2023 •

edited by ClaudiaRojasSoto

Loading

Munsa1 Oct 18, 2023 •

edited by ClaudiaRojasSoto

Loading

Munsa1 Oct 18, 2023 •

edited by ClaudiaRojasSoto

Loading