Feature/components: Implement the Calculator component #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it the calculator skeleton
…uploading the packages json on the folder
…lculator.js file inside it
…es to Calculator.js file
…ulator function on Calculator.js file
andersonlebon
approved these changes
Jul 4, 2023
There was a problem hiding this comment.
Hi @ClaudiaRojasSoto
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
To highlight 🍾
- All linters are passing ✔️
- Good commit history ✔️
- Good PR description ✔️
- Professional Readme with a project stucture ✔️
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question @andersonlebon so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request contains the implementation of the Math Magicians app's component feature. The feature includes the development of a React component called Calculator.js, which fulfills all the project requirements specified in the project description.
Changes Made:
components.Calculator.jsReact component.Calculator componentinto the top-level component (App.js).Additional Information:
This pull request fulfills all the specified learning objectives, including the use of React components, props, and state. The implementation meets the project requirements and has been documented professionally.
Please review this pull request to merge to the "develop" branch.
Thank you!
@ClaudiaRojasSoto