Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and improve quest editor (Rebased) #106

Conversation

KatatsumuriPan
Copy link

This is rebased branch of #98.


This is a response to #97.

What's Changed

  • Restored quest description editor gui (moved to a new class).
  • Both the editor gui screen (suitable for preview) and the editor window (suitable for writing) are available.
    You can open the window with the button.
  • "Juse Close" button allows to close an editor gui screen while keeping the window open, and vice versa.
  • It is still possible to have multiple quest windows open at the same time.
  • Added line numbers on the editor window.

Bug Fixes

  • Quest name and description are now correctly updated when the text field has focus.
  • Scrollbars and component sizes of the editor window was fixed.
  • The text formatting buttons now correctly replace the selected text in the editor window.

This branch contains the commits of #95.

@Rongmario Rongmario merged commit 16f0195 into CleanroomMC:1.12 Mar 14, 2024
1 check failed
@KatatsumuriPan KatatsumuriPan deleted the 1.12-improve-quest-text-editor(rebased) branch March 15, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants