Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make Back a keybind #119

Merged
merged 3 commits into from
Oct 11, 2024
Merged

make Back a keybind #119

merged 3 commits into from
Oct 11, 2024
+27 −30

Conversation

WaitingIdly
Copy link
Collaborator

changes in this PR:

  • adds a keybind to go back instead of having it be hardcoded to "14" (what are we, barbarians?).
  • keybind defaults to backspace.
  • move some duplicate code relating to closing volatile screens into a separate method in two locations.

@WaitingIdly WaitingIdly added the enhancement New feature or request label Jul 6, 2024
@Rongmario Rongmario merged commit 48ba60f into CleanroomMC:1.12 Oct 11, 2024
@WaitingIdly WaitingIdly deleted the keybind branch October 11, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rongmario Rongmario Rongmario requested changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WaitingIdly @Rongmario