Skip to content

Commit

Permalink
Fix ClimaCalibrate compat
Browse files Browse the repository at this point in the history
  • Loading branch information
nefrathenrici committed Jul 26, 2024
1 parent c8eda95 commit 0e01acb
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,4 @@ YAML = "ddb6d928-2868-570f-bddf-ab3f9cf99eb6"

[compat]
ClimaAtmos = "=0.24.0"
ClimaCalibrate = "=0.0.1"
3 changes: 3 additions & 0 deletions calibration/test/Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,6 @@ EnsembleKalmanProcesses = "aa8a2aa5-91d8-4396-bcef-d4f2ec43552d"
JLD2 = "033835bb-8acc-5ee8-8aae-3f567f8a3819"
MPI = "da04e1cc-30fd-572f-bb4f-1f8673147195"
YAML = "ddb6d928-2868-570f-bddf-ab3f9cf99eb6"

[compat]
ClimaCalibrate = "0.0.2"
18 changes: 9 additions & 9 deletions calibration/test/e2e_test.jl
Original file line number Diff line number Diff line change
Expand Up @@ -93,15 +93,15 @@ if !(@isdefined backend)
backend = CAL.get_backend()
end
@info "Running calibration E2E test" backend
if backend <: CAL.SlurmBackend
slurm_kwargs = CAL.kwargs(time = 15)
test_eki = CAL.calibrate(
backend,
experiment_config;
slurm_kwargs,
model_interface,
verbose = true,
)
if backend <: CAL.HPCBackend
hpc_kwargs =
test_eki = CAL.calibrate(
backend,
experiment_config;
hpc_kwargs = CAL.kwargs(time = 15),
model_interface,
verbose = true,
)
else
test_eki = CAL.calibrate(backend, experiment_config)
end
Expand Down
2 changes: 1 addition & 1 deletion src/solver/yaml_helper.jl
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ function override_default_config(config_dict::AbstractDict;)
end
end

excluded_keys = Set(["diagnostics"])
excluded_keys = ("diagnostics", "job_id")
unused_keys = filter(
k -> !haskey(default_config, k) && !(k in excluded_keys),
keys(config_dict),
Expand Down

0 comments on commit 0e01acb

Please sign in to comment.