Skip to content

Commit

Permalink
Merge #2261
Browse files Browse the repository at this point in the history
2261: Use SurfaceFluxes.jl v0.8.0 r=akshaysridhar a=akshaysridhar

Update sf functions to use v0.8.0 interface
	modified:   Project.toml
	modified:   src/surface_conditions/surface_conditions.jl

- [x] Check CI outcomes. 
- [x] Check longrun [outcomes. ](https://buildkite.com/clima/climaatmos-longruns/builds/1194#018b49cf-721a-46b1-b483-a839e62e5455)

Co-authored-by: akshaysridhar <asridhar@caltech.edu>
  • Loading branch information
bors[bot] and akshaysridhar authored Oct 20, 2023
2 parents 6bee1ae + 25150a8 commit 6994c4b
Show file tree
Hide file tree
Showing 14 changed files with 174 additions and 128 deletions.
8 changes: 4 additions & 4 deletions .buildkite/longruns/pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ steps:
slurm_mem_per_cpu: 16GB
slurm_time: 24:00:00

- label: ":computer: aquaplanet (ρe_tot) equilmoist clearsky high resolution (nz63) hightop (55km) rayleigh sponge(35e3, 10) Float64 (time-varying insolation)"
- label: ":computer: aquaplanet (ρe_tot) equilmoist clearsky high resolution (nz63) hightop (55km) rayleigh sponge(35e3, 10) Float32 (time-varying insolation)"
command:
- srun julia --project=examples examples/hybrid/driver.jl --config_file $CONFIG_PATH/$$JOB_NAME.yml
- julia --color=yes --project=examples post_processing/remap/remap_pipeline.jl --data_dir $$JOB_NAME --out_dir $$JOB_NAME
Expand Down Expand Up @@ -165,7 +165,7 @@ steps:
env:
JOB_NAME: "longrun_hs_rhoe_equil_highres_topography_earth"

- label: ":computer: no lim ARS aquaplanet (ρe_tot) equilmoist high resolution clearsky radiation Float64 (earth)"
- label: ":computer: no lim ARS aquaplanet (ρe_tot) equilmoist high resolution clearsky radiation Float32 (earth)"
command:
- srun julia --project=examples examples/hybrid/driver.jl --config_file $CONFIG_PATH/$$JOB_NAME.yml
- julia --color=yes --project=examples post_processing/remap/remap_pipeline.jl --data_dir $$JOB_NAME --out_dir $$JOB_NAME
Expand All @@ -176,7 +176,7 @@ steps:
slurm_mem_per_cpu: 16GB
slurm_time: 24:00:00
env:
JOB_NAME: "longrun_aquaplanet_rhoe_equil_highres_clearsky_ft64_earth"
JOB_NAME: "longrun_aquaplanet_rhoe_equil_highres_clearsky_ft32_earth"

- group: "Low resolution long runs"

Expand Down Expand Up @@ -208,7 +208,7 @@ steps:
slurm_ntasks: 32
slurm_time: 24:00:00
env:
JOB_NAME: "longrun_aquaplanet_rhoe_equil_highres_allsky_ft64"
JOB_NAME: "longrun_aquaplanet_rhoe_equil_highres_allsky_ft32"


- group: "TurbulenceConvection"
Expand Down
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ RootSolvers = "0.2, 0.3, 0.4"
SciMLBase = "1, 2"
StaticArrays = "1"
StatsBase = "0.33, 0.34"
SurfaceFluxes = "0.7.2"
SurfaceFluxes = "0.8.0"
TerminalLoggers = "0.1"
Thermodynamics = "0.11"
YAML = "0.4"
Expand Down
4 changes: 2 additions & 2 deletions config/longrun_configs/longrun_aquaplanet_amip.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ edmfx_sgs_mass_flux: true
edmfx_sgs_diffusive_flux: true
rayleigh_sponge: true
dt_save_to_disk: "3hours"
dt: "10secs"
dt: "5secs"
t_end: "1days"
FLOAT_TYPE: "Float64"
FLOAT_TYPE: "Float32"
job_id: "longrun_aquaplanet_amip"
toml: [toml/longrun_aquaplanet_amip.toml]
2 changes: 1 addition & 1 deletion config/longrun_configs/longrun_aquaplanet_dyamond.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ rayleigh_sponge: true
dt_save_to_disk: "3hours"
dt: "50secs"
t_end: "1days"
FLOAT_TYPE: "Float64"
FLOAT_TYPE: "Float32"
job_id: "longrun_aquaplanet_dyamond"
toml: [toml/longrun_aquaplanet_dyamond.toml]
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ dz_bottom: 30.0
vert_diff: "true"
h_elem: 16
kappa_4: 1.0e16
FLOAT_TYPE: "Float64"
FLOAT_TYPE: "Float32"
z_max: 45000.0
precip_model: "0M"
job_id: "longrun_aquaplanet_rhoe_equil_clearsky_highres_hightop_rayleigh35e3_ft64"
job_id: "longrun_aquaplanet_rhoe_equil_clearsky_highres_hightop_rayleigh35e3_ft32"
moist: "equil"
toml: [toml/longrun_aquaplanet_rhoe_equil_clearsky_highres_hightop_rayleigh35e3_ft64.toml]
toml: [toml/longrun_aquaplanet_rhoe_equil_clearsky_highres_hightop_rayleigh35e3_ft32.toml]
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ vert_diff: "true"
h_elem: 16
kappa_4: 1.0e16
idealized_insolation: false
FLOAT_TYPE: "Float64"
FLOAT_TYPE: "Float32"
precip_model: "0M"
job_id: "longrun_aquaplanet_rhoe_equil_highres_allsky_ft64"
job_id: "longrun_aquaplanet_rhoe_equil_highres_allsky_ft32"
moist: "equil"
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ vert_diff: "true"
h_elem: 16
use_reference_state: false
kappa_4: 3.0e16
FLOAT_TYPE: "Float64"
FLOAT_TYPE: "Float32"
precip_model: "0M"
topography: "Earth"
dt_save_to_sol: "10days"
job_id: "longrun_aquaplanet_rhoe_equil_highres_clearsky_ft64_earth"
job_id: "longrun_aquaplanet_rhoe_equil_highres_clearsky_ft32_earth"
moist: "equil"
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FLOAT_TYPE: "Float64"
FLOAT_TYPE: "Float32"
dt_save_to_disk: "10days"
dt: "150secs"
t_end: "300days"
Expand Down
84 changes: 50 additions & 34 deletions docs/Manifest.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ version = "0.2.4"

[[deps.AMD]]
deps = ["LinearAlgebra", "SparseArrays", "SuiteSparse_jll"]
git-tree-sha1 = "d4b99dd70d7136fe75ec74d072191d688448d39c"
git-tree-sha1 = "45a1272e3f809d36431e57ab22703c6896b8908f"
uuid = "14f7f29c-3bd6-536c-9a0b-7339e30b5a3e"
version = "0.5.2"
version = "0.5.3"

[[deps.ANSIColoredPrinters]]
git-tree-sha1 = "574baf8110975760d391c710b6341da1afa48d8c"
Expand Down Expand Up @@ -194,9 +194,9 @@ version = "0.1.2"

[[deps.CLIMAParameters]]
deps = ["DocStringExtensions", "TOML", "Test"]
git-tree-sha1 = "e1820c154d02ba381e9a91ea7a5870b282d32abc"
git-tree-sha1 = "d635b0e0ae4c0ba2213aac07a1c07e3b4fce5a00"
uuid = "6eacf6c3-8458-43b9-ae03-caf5306d3d53"
version = "0.7.22"
version = "0.7.23"

[[deps.CPUSummary]]
deps = ["CpuId", "IfElse", "PrecompileTools", "Static"]
Expand Down Expand Up @@ -241,10 +241,14 @@ uuid = "aafaddc9-749c-510e-ac4f-586e18779b91"
version = "0.2.2"

[[deps.ChainRulesCore]]
deps = ["Compat", "LinearAlgebra", "SparseArrays"]
git-tree-sha1 = "b66b8f8e3db5d7835fb8cbe2589ffd1cd456e491"
deps = ["Compat", "LinearAlgebra"]
git-tree-sha1 = "e0af648f0692ec1691b5d094b8724ba1346281cf"
uuid = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"
version = "1.17.0"
version = "1.18.0"
weakdeps = ["SparseArrays"]

[deps.ChainRulesCore.extensions]
ChainRulesCoreSparseArraysExt = "SparseArrays"

[[deps.ClimaAtmos]]
deps = ["ArgParse", "ArtifactWrappers", "Artifacts", "AtmosphericProfilesLibrary", "CLIMAParameters", "CUDA", "ClimaComms", "ClimaCore", "ClimaTimeSteppers", "CloudMicrophysics", "Colors", "Dates", "Dierckx", "DiffEqBase", "DiffEqCallbacks", "Distributions", "DocStringExtensions", "FastGaussQuadrature", "ImageFiltering", "Insolation", "Interpolations", "IntervalSets", "JLD2", "Krylov", "LambertW", "LinearAlgebra", "Logging", "NCDatasets", "NVTX", "OrdinaryDiffEq", "Pkg", "Printf", "RRTMGP", "Random", "RootSolvers", "SciMLBase", "StaticArrays", "Statistics", "StatsBase", "SurfaceFluxes", "TerminalLoggers", "Test", "Thermodynamics", "YAML"]
Expand All @@ -260,9 +264,9 @@ version = "0.5.5"

[[deps.ClimaCore]]
deps = ["Adapt", "BandedMatrices", "BlockArrays", "CUDA", "ClimaComms", "CubedSphere", "DataStructures", "DocStringExtensions", "ForwardDiff", "GaussQuadrature", "GilbertCurves", "HDF5", "InteractiveUtils", "IntervalSets", "LinearAlgebra", "PkgVersion", "RecursiveArrayTools", "Requires", "RootSolvers", "SparseArrays", "Static", "StaticArrays", "Statistics", "UnPack"]
git-tree-sha1 = "690b1737d6e8bfb67e8f9d4f54b37732d02f50b0"
git-tree-sha1 = "8174265fe74081f378b11e36962c3b9cbb11c44f"
uuid = "d414da3d-4745-48bb-8d80-42e94e092884"
version = "0.10.53"
version = "0.10.54"

[[deps.ClimaTimeSteppers]]
deps = ["CUDA", "ClimaComms", "Colors", "DataStructures", "DiffEqBase", "DiffEqCallbacks", "KernelAbstractions", "Krylov", "LinearAlgebra", "LinearOperators", "NVTX", "SciMLBase", "StaticArrays"]
Expand Down Expand Up @@ -612,9 +616,9 @@ uuid = "7b1f6079-737a-58dc-b8bc-7a2ca5c1b5ee"

[[deps.FillArrays]]
deps = ["LinearAlgebra", "Random"]
git-tree-sha1 = "a20eaa3ad64254c61eeb5f230d9306e937405434"
git-tree-sha1 = "35f0c0f345bff2c6d636f95fdb136323b5a796ef"
uuid = "1a297f60-69ca-5386-bcde-b61e274b549b"
version = "1.6.1"
version = "1.7.0"
weakdeps = ["SparseArrays", "Statistics"]

[deps.FillArrays.extensions]
Expand Down Expand Up @@ -879,9 +883,9 @@ version = "0.9.4"

[[deps.LDLFactorizations]]
deps = ["AMD", "LinearAlgebra", "SparseArrays", "Test"]
git-tree-sha1 = "cbf4b646f82bfc58bb48bcca9dcce2eb88da4cd1"
git-tree-sha1 = "70f582b446a1c3ad82cf87e62b878668beef9d13"
uuid = "40e66cde-538c-5869-a4ad-c39174c6795b"
version = "0.10.0"
version = "0.10.1"

[[deps.LLVM]]
deps = ["CEnum", "LLVMExtra_jll", "Libdl", "Printf", "Unicode"]
Expand Down Expand Up @@ -984,11 +988,12 @@ version = "2.5.2"

[[deps.LinearSolve]]
deps = ["ArrayInterface", "ConcreteStructs", "DocStringExtensions", "EnumX", "EnzymeCore", "FastLapackInterface", "GPUArraysCore", "InteractiveUtils", "KLU", "Krylov", "Libdl", "LinearAlgebra", "MKL_jll", "PrecompileTools", "Preferences", "RecursiveFactorization", "Reexport", "Requires", "SciMLBase", "SciMLOperators", "Setfield", "SparseArrays", "Sparspak", "SuiteSparse", "UnPack"]
git-tree-sha1 = "9f27ba34f5821a0495efb09ea3a465c31326495a"
git-tree-sha1 = "31353ba539d14a342908f765407abffd8db5f3c7"
uuid = "7ed4a6bd-45f5-4d41-b270-4a48e9bafcae"
version = "2.10.0"
version = "2.11.0"

[deps.LinearSolve.extensions]
LinearSolveBandedMatricesExt = "BandedMatrices"
LinearSolveBlockDiagonalsExt = "BlockDiagonals"
LinearSolveCUDAExt = "CUDA"
LinearSolveEnzymeExt = "Enzyme"
Expand All @@ -998,8 +1003,10 @@ version = "2.10.0"
LinearSolveKrylovKitExt = "KrylovKit"
LinearSolveMetalExt = "Metal"
LinearSolvePardisoExt = "Pardiso"
LinearSolveRecursiveArrayToolsExt = "RecursiveArrayTools"

[deps.LinearSolve.weakdeps]
BandedMatrices = "aae01518-5342-5314-be14-df237901396f"
BlockDiagonals = "0a1fb500-61f7-11e9-3c65-f5ef3456f9f0"
CUDA = "052768ef-5323-5732-b1bb-66c8b64840ba"
Enzyme = "7da242da-08ed-463a-9acd-ee780be4f1d9"
Expand All @@ -1009,6 +1016,7 @@ version = "2.10.0"
KrylovKit = "0b1a1467-8014-51b9-945f-bf0ae24f4b77"
Metal = "dde4c033-4e86-420c-a63e-0dd931031962"
Pardiso = "46dd5b70-b6fb-5a00-ae2d-e8fea33afaf2"
RecursiveArrayTools = "731186ca-8d62-57ce-b412-fbd966d074cd"

[[deps.LogExpFunctions]]
deps = ["DocStringExtensions", "IrrationalConstants", "LinearAlgebra"]
Expand Down Expand Up @@ -1187,9 +1195,17 @@ version = "1.2.0"

[[deps.NonlinearSolve]]
deps = ["ADTypes", "ArrayInterface", "ConcreteStructs", "DiffEqBase", "EnumX", "FiniteDiff", "ForwardDiff", "LineSearches", "LinearAlgebra", "LinearSolve", "PrecompileTools", "RecursiveArrayTools", "Reexport", "SciMLBase", "SimpleNonlinearSolve", "SparseArrays", "SparseDiffTools", "StaticArraysCore", "UnPack"]
git-tree-sha1 = "a5f1f836da05d513c4143576af8f5d8e51b759f5"
git-tree-sha1 = "ee92770e0832314ccd424d83a0ab4c75fc6dc91f"
uuid = "8913a72c-1f9b-4ce2-8d82-65094dcecaec"
version = "2.2.1"
version = "2.3.0"

[deps.NonlinearSolve.extensions]
NonlinearSolveFastLevenbergMarquardtExt = "FastLevenbergMarquardt"
NonlinearSolveLeastSquaresOptimExt = "LeastSquaresOptim"

[deps.NonlinearSolve.weakdeps]
FastLevenbergMarquardt = "7a0df574-e128-4d35-8cbd-3d84502bf7ce"
LeastSquaresOptim = "0fc2ff8b-aaa3-5acd-a817-1944a5e08891"

[[deps.OffsetArrays]]
deps = ["Adapt"]
Expand Down Expand Up @@ -1238,9 +1254,9 @@ version = "6.58.0"

[[deps.PDMats]]
deps = ["LinearAlgebra", "SparseArrays", "SuiteSparse"]
git-tree-sha1 = "d1b5f455bdd787aa7ac35d1f31f0bdb5d396ba27"
git-tree-sha1 = "66b2fcd977db5329aa35cac121e5b94dd6472198"
uuid = "90014a1f-27ba-587c-ab20-58faa44d9150"
version = "0.11.27"
version = "0.11.28"

[[deps.PackageExtensionCompat]]
git-tree-sha1 = "fb28e33b8a95c4cee25ce296c817d89cc2e53518"
Expand Down Expand Up @@ -1315,9 +1331,9 @@ version = "1.4.1"

[[deps.PrettyTables]]
deps = ["Crayons", "LaTeXStrings", "Markdown", "Printf", "Reexport", "StringManipulation", "Tables"]
git-tree-sha1 = "ee094908d720185ddbdc58dbe0c1cbe35453ec7a"
git-tree-sha1 = "6842ce83a836fbbc0cfeca0b5a4de1a4dcbdb8d1"
uuid = "08abe8d2-0d0c-5749-adfa-8a2ac140af0d"
version = "2.2.7"
version = "2.2.8"

[[deps.Printf]]
deps = ["Unicode"]
Expand Down Expand Up @@ -1385,9 +1401,9 @@ version = "1.3.4"

[[deps.RecursiveArrayTools]]
deps = ["Adapt", "ArrayInterface", "DocStringExtensions", "GPUArraysCore", "IteratorInterfaceExtensions", "LinearAlgebra", "RecipesBase", "Requires", "StaticArraysCore", "Statistics", "SymbolicIndexingInterface", "Tables"]
git-tree-sha1 = "fa453b42ba1623bd2e70260bf44dac850a3430a7"
git-tree-sha1 = "d7087c013e8a496ff396bae843b1e16d9a30ede8"
uuid = "731186ca-8d62-57ce-b412-fbd966d074cd"
version = "2.39.0"
version = "2.38.10"

[deps.RecursiveArrayTools.extensions]
RecursiveArrayToolsMeasurementsExt = "Measurements"
Expand Down Expand Up @@ -1465,9 +1481,9 @@ version = "0.6.39"

[[deps.SciMLBase]]
deps = ["ADTypes", "ArrayInterface", "ChainRulesCore", "CommonSolve", "ConstructionBase", "Distributed", "DocStringExtensions", "EnumX", "FillArrays", "FunctionWrappersWrappers", "IteratorInterfaceExtensions", "LinearAlgebra", "Logging", "Markdown", "PrecompileTools", "Preferences", "RecipesBase", "RecursiveArrayTools", "Reexport", "RuntimeGeneratedFunctions", "SciMLOperators", "StaticArraysCore", "Statistics", "SymbolicIndexingInterface", "Tables", "TruncatedStacktraces", "ZygoteRules"]
git-tree-sha1 = "317f77cb31f7a0275cdd045aa7b3526ebc15c817"
git-tree-sha1 = "6134c8970f82f23c43d3580d79c3e47acf232083"
uuid = "0bca4576-84f4-4d90-8ffe-ffa030f20462"
version = "2.4.0"
version = "2.4.1"

[deps.SciMLBase.extensions]
SciMLBasePyCallExt = "PyCall"
Expand Down Expand Up @@ -1514,9 +1530,9 @@ uuid = "1a1011a3-84de-559e-8e89-a11a2f7dc383"

[[deps.SimpleNonlinearSolve]]
deps = ["ArrayInterface", "DiffEqBase", "FiniteDiff", "ForwardDiff", "LinearAlgebra", "PackageExtensionCompat", "PrecompileTools", "Reexport", "SciMLBase", "StaticArraysCore"]
git-tree-sha1 = "4d53b83af904049c493daaf2a225bcae994a3c59"
git-tree-sha1 = "e308d089f5d0e733a017b61784c5813e672f760d"
uuid = "727e6d20-b764-4bd8-a329-72de5adea6c7"
version = "0.1.20"
version = "0.1.22"

[deps.SimpleNonlinearSolve.extensions]
SimpleNonlinearSolveNNlibExt = "NNlib"
Expand Down Expand Up @@ -1546,9 +1562,9 @@ uuid = "6462fe0b-24de-5631-8697-dd941f90decc"

[[deps.SortingAlgorithms]]
deps = ["DataStructures"]
git-tree-sha1 = "c60ec5c62180f27efea3ba2908480f8055e17cee"
git-tree-sha1 = "5165dfb9fd131cf0c6957a3a7605dede376e7b63"
uuid = "a2af1166-a08f-5f64-846c-94a0d3cef48c"
version = "1.1.1"
version = "1.2.0"

[[deps.SparseArrays]]
deps = ["Libdl", "LinearAlgebra", "Random", "Serialization", "SuiteSparse_jll"]
Expand Down Expand Up @@ -1689,10 +1705,10 @@ uuid = "bea87d4a-7f5b-5778-9afe-8cc45184846c"
version = "5.10.1+6"

[[deps.SurfaceFluxes]]
deps = ["DocStringExtensions", "KernelAbstractions", "Logging", "RootSolvers", "StaticArrays", "Thermodynamics"]
git-tree-sha1 = "0f82dcffc203c9d4a8ea54cb0b05ec5730117744"
deps = ["CLIMAParameters", "DocStringExtensions", "Logging", "RootSolvers", "Thermodynamics"]
git-tree-sha1 = "7f83013a0654d6504226d93ba0cba94d94e1b0b0"
uuid = "49b00bb7-8bd4-4f2b-b78c-51cd0450215f"
version = "0.7.2"
version = "0.8.0"

[[deps.SymbolicIndexingInterface]]
deps = ["DocStringExtensions"]
Expand Down Expand Up @@ -1780,9 +1796,9 @@ uuid = "a759f4b9-e2f1-59dc-863e-4aeb61b1ea8f"
version = "0.5.23"

[[deps.TranscodingStreams]]
git-tree-sha1 = "7c9196c8c83802d7b8ca7a6551a0236edd3bf731"
git-tree-sha1 = "49cbf7c74fafaed4c529d47d48c8f7da6a19eb75"
uuid = "3bb67fe8-82b1-5028-8e26-92a6c54297fa"
version = "0.10.0"
version = "0.10.1"
weakdeps = ["Random", "Test"]

[deps.TranscodingStreams.extensions]
Expand Down
Loading

0 comments on commit 6994c4b

Please sign in to comment.