Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify parameter sets #1199

Closed
charleskawczynski opened this issue Dec 12, 2022 · 1 comment · Fixed by #2017
Closed

Unify parameter sets #1199

charleskawczynski opened this issue Dec 12, 2022 · 1 comment · Fixed by #2017
Assignees

Comments

@charleskawczynski
Copy link
Member

charleskawczynski commented Dec 12, 2022

We should probably try to unify our clima parameters, which are switched depending on the configuration

This could be fixed in two ways:

  • simply pick a set of parameter values, and see if all experiments work with those values. This may be difficult if some experiments are breaking, but it could require the least code changes since we could technically just delete all the overrides (if all the experiments just worked).
  • we could create 3 toml files with overrides based on the if-else if-else blocks in the link above. Then specify the correct toml override in all of the appropriate buildkite jobs so that there are no behavioral changes. The result is that this function could simply create the parameters with the toml override. This is simple in the sense that we can easily solve this by making no behavioral changes, but it will require carefully figuring out which set of parameters each buildkite job is using. My tip here would be to add a print in the if-elseif-else block and run CI, then collect the information from the log. That would take a lot of guess/investigatory work out
@nefrathenrici
Copy link
Member

nefrathenrici commented Aug 25, 2023

Option 2 requires 50+ CI runs to use toml files. I would rather try to have a unified parameter set, so I will pick one set of parameter values that minimizes MSE / pipeline crashes. If there are runs that really don't work well, we can override them with a minimal toml file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants