Remove case-specific overrides from parameter creation

[nefrathenrici]

Content

• Removes case-specific parameter overrides. This changes simulation results, which have been checked by @szy21 (including longruns). Relevant builds: default pipeline, longruns
• The exception to the above is τ_precip, which is still set to dt in all cases. This is the same behavior as before, and but can now be switched off by setting the new config flag override_τ_precip = false
• Adds a function create_parameter_struct which takes in a parameter struct type, any nested parameter structs, and constructs the parameters. This cleans up a lot of boilerplate from create_parameter_set
• Removes unused parameters: ug, vg, f, and Cd. It was hard to grep for usage of f but all of my local tests work.
• Sets f_plane_coriolis_frequencyvia CLIMAParameters instead of a hardcoded value. The default value is unchanged

[Sbozzolo]

Where/how is τ_precip used? I don't see any reference to it in ClimaAtmos except in setting the parameter

[nefrathenrici]

Where/how is τ_precip used? I don't see any reference to it in ClimaAtmos except in setting the parameter

@Sbozzolo It's used in CloudMicrophysics and is used in periodically removing precipitation in the 0Moment microphysics scheme. It's kind of an exception since it is always set to dt. There is likely a better way of passing it through to CloudMicrophysics but I just want to get rid of the case-specific overrides for now!

[Sbozzolo]

Where/how is τ_precip used? I don't see any reference to it in ClimaAtmos except in setting the parameter

@Sbozzolo It's used in CloudMicrophysics and is used in periodically removing precipitation in the 0Moment microphysics scheme. It's kind of an exception since it is always set to dt. There is likely a better way of passing it through to CloudMicrophysics but I just want to get rid of the case-specific overrides for now!

Thanks! How is it passed to CloudMicrophysics? If it is always set to dt, maybe we can implement it as a callback that executes at the end of each integration step?

(My interest in this stems from the fact that I am studying how to remove explicit references to parsed_args past the configuration stage.)

[szy21]

It would be better to just ask the user to specify both τ_precip and dt. They don't have to be the same.

[nefrathenrici]

@Sbozzolo I'm not sure how it would work as a callback, since it needs to be passed in as a parameter to CloudMicrophysics, but I'm open to changing how it's set.

[charleskawczynski]

Changes overall LGTM

[nefrathenrici]

bors r+

[bors]

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

• buildkite/climaatmos-ci
• docbuild
• format