Use 3D curl in vector hyperdiffusion #2006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbyrne
force-pushed
the
sb/hyperdiff
branch
from
bb6ab74 to
4cc117f
Compare
simonbyrne
force-pushed
the
sb/hyperdiff
branch
3 times, most recently
from
8004521 to
fd7402c
Compare
4 tasks
szy21
approved these changes
Sep 2, 2023
|
There's probably some small numerical change, but it shouldn't be behavior changing. |
Right, I meant the mse change. The results look good to me. |
bors bot
added a commit
to CliMA/ClimaCore.jl
that referenced
this pull request
Sep 3, 2023
1440: add curl methods for plane config r=simonbyrne a=simonbyrne These are currently missing, needed for CliMA/ClimaAtmos.jl#2006 - [x] Code follows the [style guidelines](https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/) OR N/A. - [x] Unit tests are included OR N/A. - [x] Code is exercised in an integration test OR N/A. - [x] Documentation has been added/updated OR N/A. Co-authored-by: Simon Byrne <simonbyrne@gmail.com>
bors bot
added a commit
to CliMA/ClimaCore.jl
that referenced
this pull request
Sep 5, 2023
1440: add curl methods for plane config r=simonbyrne a=simonbyrne These are currently missing, needed for CliMA/ClimaAtmos.jl#2006 - [x] Code follows the [style guidelines](https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/) OR N/A. - [x] Unit tests are included OR N/A. - [x] Code is exercised in an integration test OR N/A. - [x] Documentation has been added/updated OR N/A. 1446: Upgrade to Julia 1.9.3 r=charleskawczynski a=charleskawczynski This PR upgrades us to Julia 1.9.3 and updates the manifest files. Co-authored-by: Simon Byrne <simonbyrne@gmail.com> Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
bors bot
added a commit
to CliMA/ClimaCore.jl
that referenced
this pull request
Sep 5, 2023
1440: add curl methods for plane config r=simonbyrne a=simonbyrne These are currently missing, needed for CliMA/ClimaAtmos.jl#2006 - [x] Code follows the [style guidelines](https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/) OR N/A. - [x] Unit tests are included OR N/A. - [x] Code is exercised in an integration test OR N/A. - [x] Documentation has been added/updated OR N/A. Co-authored-by: Simon Byrne <simonbyrne@gmail.com>
simonbyrne
force-pushed
the
sb/hyperdiff
branch
from
fd7402c to
c1c728a
Compare
|
Longruns available here: https://buildkite.com/clima/climaatmos-longruns/builds/1166 @szy21 do they look okay? |
simonbyrne
force-pushed
the
sb/hyperdiff
branch
from
c1c728a to
ee10d65
Compare
|
The longrun looks good to me. |
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This switches to using the 3D spectral element curl (CliMA/ClimaCore.jl#1425) in hyperdiffusion.
To-do
Content