Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new implicit solver interface #2044

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Update to new implicit solver interface #2044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d98e7c6
Update to new implicit solver interface
dennisYatunin Aug 31, 2023
40cae18
Bump ref counter
dennisYatunin Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/src/api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,3 +47,9 @@ ClimaAtmos.InitialConditions.LifeCycleTan2018
ClimaAtmos.InitialConditions.Bomex
ClimaAtmos.InitialConditions.Soares
```

### Implicit Solver

```@docs
ClimaAtmos.ImplicitEquationJacobian
```
2 changes: 1 addition & 1 deletion regression_tests/ref_counter.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
133
134
3 changes: 1 addition & 2 deletions src/ClimaAtmos.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,8 @@ include(joinpath("utils", "discrete_hydrostatic_balance.jl"))
include(joinpath("prognostic_equations", "pressure_work.jl"))
include(joinpath("prognostic_equations", "zero_velocity.jl"))

include(joinpath("prognostic_equations", "implicit", "wfact.jl"))
include(joinpath("prognostic_equations", "implicit", "schur_complement_W.jl"))
include(joinpath("prognostic_equations", "implicit", "implicit_tendency.jl"))
include(joinpath("prognostic_equations", "implicit", "implicit_solver.jl"))

include(joinpath("prognostic_equations", "remaining_tendency.jl"))
include(joinpath("prognostic_equations", "forcing", "large_scale_advection.jl")) # TODO: should this be in tendencies/?
Expand Down
7 changes: 2 additions & 5 deletions src/cache/cache.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using LinearAlgebra: ×, norm, dot
using LinearAlgebra: ×, norm, dot, Adjoint

import .Parameters as CAP
using ClimaCore: Operators, Fields, Limiters, Geometry, Spaces
Expand Down Expand Up @@ -94,10 +94,7 @@ function default_cache(
ᶜp_ref,
ᶜT = similar(Y.c, FT),
ᶜf,
∂ᶜK∂ᶠu₃_data = similar(
Y.c,
Operators.StencilCoefs{-half, half, NTuple{2, FT}},
),
∂ᶜK_∂ᶠu₃ = similar(Y.c, BidiagonalMatrixRow{Adjoint{FT, CT3{FT}}}),
params,
energy_upwinding,
tracer_upwinding,
Expand Down
1 change: 0 additions & 1 deletion src/dycore_equations_deprecated/sgs_flux_tendencies.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
using LinearAlgebra
import OrdinaryDiffEq as ODE
import Logging
import TerminalLoggers
Expand Down
Loading
Loading