Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update packages #2047

Merged
merged 1 commit into from
Sep 3, 2023
Merged

update packages #2047

merged 1 commit into from
Sep 3, 2023

Conversation

trontrytel
Copy link
Member

Updates to the new releases of Thermodynamics, CloudMicrophysics and SurfaceFluxes

Copy link
Member

@charleskawczynski charleskawczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we need to update the compats in the test env

@trontrytel
Copy link
Member Author

The code works, but I'm getting complaints from four flame graph tests:

perf target (edmfx): 301760 ≤ 298688 (1% increase)
perf target (diagnostic edmfx): 678672 ≤ 664336 (2% increase)
perf target (edmf): 8953312080 ≤ 8282903376 (8% increase)
gravity wave: 4964581344 ≤ 4937136096 (0.5% increase)

The things that changed in CloudMicrophysics.jl:

  • adding more parameters to our big parameter struct
  • adding another type to dispatch over in the 1-moment scheme (all edmfx and the gravity wave test use 0-moment scheme)

The things that changed in Thermodynamics.jl:

  • adding a parameter to parameter struct.

@charleskawczynski
Copy link
Member

Let’s just increase the limits, and merge 🙂

@trontrytel
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 3, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate between MSLP and theta reference pressure
2 participants