Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up warnings in docs #2067

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Clean up warnings in docs #2067

merged 1 commit into from
Sep 7, 2023

Conversation

Sbozzolo
Copy link
Member

@Sbozzolo Sbozzolo commented Sep 6, 2023

The documentation is generated with a few warnings and one error (see, e.g., https://github.com/CliMA/ClimaAtmos.jl/actions/runs/6101954504/job/16559376893#step:5:8).

The error is due to an incompatibility between doctest and CitationBibliography. I reported the problem upstream. The error is not fatal.

@Sbozzolo Sbozzolo added documentation Improvements or additions to documentation House cleaning 🧹 labels Sep 6, 2023
Copy link
Member

@nefrathenrici nefrathenrici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this up! Just one comment

docs/src/parameters.md Outdated Show resolved Hide resolved
@Sbozzolo
Copy link
Member Author

Sbozzolo commented Sep 6, 2023

Done

@Sbozzolo
Copy link
Member Author

Sbozzolo commented Sep 7, 2023

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 7, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 17d9571 into main Sep 7, 2023
8 checks passed
@bors bors bot deleted the gb/clean_docs branch September 7, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation House cleaning 🧹
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants