Correct the shear production in diagnostic edmf #2072
Conversation
| ᶜgradᵥ_ᶠuvw⁰ = p.ᶜtemp_UVWxUVW | ||
| ᶜgradᵥ_ᶠuvw⁰ = | ||
| Geometry.project.(Ref(Geometry.UVWAxis()), ᶜgradᵥ.(UVW.(ᶠu⁰))) | ||
| @. ᶜshear² = norm_sqr((ᶜgradᵥ_ᶠuvw⁰ + adjoint(ᶜgradᵥ_ᶠuvw⁰)) / 2) |
There was a problem hiding this comment.
It may be better to first define the strain rate (ᶜgradᵥ_ᶠuvw⁰ + adjoint(ᶜgradᵥ_ᶠuvw⁰)) / 2, since we need that for momentum diffusion, and then compute the norm of that. Instead of shear^2, a better name might be strain_norm or something like it.
There was a problem hiding this comment.
I isolated the strain rate calculation in the function compute_strain_rate! (It currently computes the strain rate at the center, we can add the one that computes it at the face when we need it.) I also renamed shear^2 to strain_rate_norm.
szy21
force-pushed
the
zs/diagedmf_shear
branch
from
42c54b5 to
7b96ed3
Compare
szy21
force-pushed
the
zs/diagedmf_shear
branch
from
7b96ed3 to
088ab13
Compare
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Purpose
Closes #1880
To-do
Content