Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat idealized_{insolation,clouds} as idealized_h20 #2078

Merged
merged 1 commit into from
Sep 9, 2023
Merged

Treat idealized_{insolation,clouds} as idealized_h20 #2078

merged 1 commit into from
Sep 9, 2023

Conversation

Sbozzolo
Copy link
Member

@Sbozzolo Sbozzolo commented Sep 8, 2023

This commit puts idealized_insoluation and idealized_clouds on the same footing as idealized_h20. As a result, it also removes the need to use parsed_args in the computation of the cache.

szy21
szy21 approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@szy21 szy21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Sbozzolo
Copy link
Member Author

Sbozzolo commented Sep 8, 2023

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 9, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 565edb3 into main Sep 9, 2023
8 checks passed
@bors bors bot deleted the gb/idealized_ins_cloud branch September 9, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szy21 szy21 szy21 approved these changes

Assignees
No one assigned
Labels
Consistency 🎯 House cleaning 🧹
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sbozzolo @szy21