Try to fix FieldVector inference #2079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We will delete this folder soon (hopefully next week). I wonder if we need to fix this, or it it a more general issue? |
Sounds good to me, this is more to see if these changes will fix the issue in light of CliMA/ClimaCore.jl#1441 |
4 tasks
charleskawczynski
force-pushed
the
ck/try_to_fix_fv_inference
branch
3 times, most recently
from
b5543c2 to
01fe291
Compare
Skip calling Fields.wrap
charleskawczynski
force-pushed
the
ck/try_to_fix_fv_inference
branch
2 times, most recently
from
ba08c9e to
5103d5f
Compare
charleskawczynski
force-pushed
the
ck/try_to_fix_fv_inference
branch
from
5103d5f to
285a506
Compare
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to fix the very bad remaining inference failure in the TC step! function, by calling a different FieldVector constructor to avoid the inference failure in (what I assume is
promote_type(map(RecursiveArrayTools.recursive_bottom_eltype, values)...)).Inference currently looks like this in the EDMF flame graph:
Let's see if this PR has any impact.
cc @LenkaNovak, @akshaysridhar
This is why I suggested adding JET tests in CliMA/ClimaCore.jl#1441, it will work, but it will be impractically slow. This flame graph is for a column, I imagine the sphere would be much worse.