Remove hardcoded parameters, minor improvements for parameters-as-functions

[nefrathenrici]

Content

• Removes entr_coeff detr_coeff and entr_tau from the config, makes them parameters
• • Update edmfx_bomex_box_v2.toml to include the detr_coeff change
• Adds parameters for previously hardcoded values in the held suarez forcing_tendency, update the parameter struct accordingly
• Removes SpongeParameters - I think we can keep these in the top-level struct
• Improves the parameter functions, auto-generate them using @eval
• Adds some tests to ensure parameters are properly read in. I introduced a bug in the atmos tomls where different parameters had the same alias, leading to parameters not being properly set. This bug has been fixed by ClimaParameters #136, which also includes an error check for unique aliases.

Note: This does not get rid of all hardcoded parameters, only the high-priority ones.

[szy21]

Looks good, thanks! In general, how do we determine if some parameters (e.g. sponge) should be in the top-level struct?

[nefrathenrici]

Looks good, thanks! In general, how do we determine if some parameters (e.g. sponge) should be in the top-level struct?

For now, we can just keep adding parameters to the top level because there aren't too many. If we keep adding parameters, we should probably find better ways to break them up.

[nefrathenrici]

bors r+

[bors]

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

• buildkite/climaatmos-ci
• docbuild
• format