Use weak divergence in scalar advection #2091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
tryBuild failed: |
simonbyrne
commented
Sep 17, 2023
simonbyrne
force-pushed
the
sb/weak-div
branch
2 times, most recently
from
c7db48c to
970c0c6
Compare
|
bors r+ |
|
Build failed: |
simonbyrne
force-pushed
the
sb/weak-div
branch
from
970c0c6 to
3b48dd5
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 18, 2023
2080: Use Covariant123Vector DSS for Hyperdiffusion tendency r=sriharshakandala a=sriharshakandala 2091: Use weak divergence in scalar advection r=simonbyrne a=simonbyrne Co-authored-by: sriharshakandala <sriharsha.kvs@gmail.com> Co-authored-by: Simon Byrne <simonbyrne@gmail.com>
|
Build failed (retrying...): |
|
Build failed: |
simonbyrne
force-pushed
the
sb/weak-div
branch
from
3b48dd5 to
ce41d13
Compare
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
If we use weak divergence for advection, then no mass is transported between elements until the DSS operation is performed. This means that we can guarantee that the total mass in the element is non-negative (and so don't need to borrow horizontally).
To-do
Content