Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove DSS on remaining tendency #2092

Merged
merged 2 commits into from
Sep 21, 2023
Merged

remove DSS on remaining tendency #2092

merged 2 commits into from
Sep 21, 2023

Conversation

simonbyrne
Copy link
Member

Purpose

This shouldn't be needed, as we do it in the timestepper.

To-do

Content


  • I have read and checked the items on the review checklist.

@szy21 szy21 closed this Sep 16, 2023
@szy21 szy21 reopened this Sep 16, 2023
@szy21
Copy link
Member

szy21 commented Sep 17, 2023

This changes MSE. Is it as expected?

@simonbyrne
Copy link
Member Author

Should only be at machine error

Copy link
Member

@szy21 szy21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The results look good to me.

@simonbyrne simonbyrne force-pushed the sb/dss-remaining branch 2 times, most recently from aff87f8 to 3226454 Compare September 18, 2023 19:23
@simonbyrne
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Sep 18, 2023
2092: remove DSS on remaining tendency r=simonbyrne a=simonbyrne



Co-authored-by: Simon Byrne <simonbyrne@gmail.com>
@bors
Copy link
Contributor

bors bot commented Sep 18, 2023

Build failed:

@simonbyrne
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 21, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit e2268a7 into main Sep 21, 2023
8 checks passed
@bors bors bot deleted the sb/dss-remaining branch September 21, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants