Fix closures resulting in boxed variables #2137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/fix_diagnostics_closure
branch
2 times, most recently
from
0e9d93c to
d1de842
Compare
charleskawczynski
force-pushed
the
ck/fix_diagnostics_closure
branch
from
d1de842 to
6663019
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 22, 2023
2137: Fix closures resulting in boxed variables r=charleskawczynski a=charleskawczynski This PR fixes a closure in the diagnostics, which results in boxing variables. Issue found in https://buildkite.com/clima/climaatmos-ci/builds/13072#018ab62d-8432-4918-8532-8c2bed825ff0 2141: Update dependencies r=charleskawczynski a=charleskawczynski This PR upgrades the dependencies, including ClimaTimeSteppers. The new version fuses some operations, resulting in precision error differences. Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
|
Build failed (retrying...): |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a closure in the diagnostics, which results in boxing variables. Issue found in https://buildkite.com/clima/climaatmos-ci/builds/13072#018ab62d-8432-4918-8532-8c2bed825ff0