Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

limit mixing length by z - z_sfc #2164

Merged
merged 1 commit into from
Sep 28, 2023
Merged

limit mixing length by z - z_sfc #2164

merged 1 commit into from
Sep 28, 2023

Conversation

szy21
Copy link
Member

@szy21 szy21 commented Sep 28, 2023

Purpose

Replace the upper limit of mixing length (l_max, default 1e6) by z - z_sfc.

To-do

Content

  • I have read and checked the items on the review checklist.

@szy21
Copy link
Member Author

szy21 commented Sep 28, 2023

@tapios Is it ok to do this, or is it better to limit the smooth minimum by z - z_sfc? It probably doesn't make any difference. I did this so that we can remove l_max altogether.

tapios
tapios approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@tapios tapios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine.

@szy21 szy21 force-pushed the zs/limit_mixing_length branch from a93c95a to a28d86a Compare September 28, 2023 05:35
@szy21
Copy link
Member Author

szy21 commented Sep 28, 2023

bors r+

bors bot added a commit that referenced this pull request Sep 28, 2023
@bors @szy21
Merge #2164
09f16f0 
2164: limit mixing length by z - z_sfc r=szy21 a=szy21



Co-authored-by: Zhaoyi Shen <11598433+szy21@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Sep 28, 2023

Build failed:

@szy21
Copy link
Member Author

szy21 commented Sep 28, 2023

bors r+

bors bot added a commit that referenced this pull request Sep 28, 2023
@bors @szy21
Merge #2164
fbd3d12 
2164: limit mixing length by z - z_sfc r=szy21 a=szy21



Co-authored-by: Zhaoyi Shen <11598433+szy21@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Sep 28, 2023

Build failed:

@szy21
Copy link
Member Author

szy21 commented Sep 28, 2023

bors r+

bors bot added a commit that referenced this pull request Sep 28, 2023
@bors @szy21
Merge #2164
10fbb8f 
2164: limit mixing length by z - z_sfc r=szy21 a=szy21



Co-authored-by: Zhaoyi Shen <11598433+szy21@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Sep 28, 2023

Build failed:

@szy21
Copy link
Member Author

szy21 commented Sep 28, 2023

bors r+

bors bot added a commit that referenced this pull request Sep 28, 2023
@bors @sriharshakandala @szy21
Merge #2155 #2164
3ed5dbf 
2155: Add 4 process run for dry baroclinic wave r=sriharshakandala a=sriharshakandala



2164: limit mixing length by z - z_sfc r=szy21 a=szy21



Co-authored-by: sriharshakandala <sriharsha.kvs@gmail.com>
Co-authored-by: Zhaoyi Shen <11598433+szy21@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Sep 28, 2023

Build failed (retrying...):

@szy21 szy21 self-assigned this Sep 28, 2023
@bors
Copy link
Contributor

bors bot commented Sep 28, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 3adc998 into main Sep 28, 2023
6 checks passed
@bors bors bot deleted the zs/limit_mixing_length branch September 28, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tapios tapios tapios approved these changes

Assignees

@szy21 szy21

Labels
None yet
Projects
None yet
Milestone
O1.5.1b Run implicit diagnostic EDMF ...
Development

Successfully merging this pull request may close these issues.
2 participants
@szy21 @tapios