Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to latest ClimaTimSteppers, minimally call set_precomputed_quantities! #2187

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Upgrade to latest ClimaTimSteppers, minimally call set_precomputed_quantities! #2187

merged 3 commits into from
Oct 4, 2023

Conversation

charleskawczynski
Copy link
Member

@charleskawczynski charleskawczynski commented Oct 4, 2023 •
edited
Loading

This PR:

  • Upgrades to the latest ClimaTimeSteppers and
  • Minimally calls set_precomputed_quantities!

Together with #2186, this PR closes #2015. Supersedes #2175, and #2145.

@charleskawczynski charleskawczynski force-pushed the ck/up_cts branch 2 times, most recently from 97eca22 to a9859ad Compare October 4, 2023 16:45
@charleskawczynski
Remove ClimaAtmos custom time stepper
0c80118 
Remove additional calls to SPQ

Remove include of timestepper folder
@charleskawczynski
Update manifests
f778136
@charleskawczynski
Increase allocation limit
a4a35d9
@charleskawczynski
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 4, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 3a80801 into main Oct 4, 2023
6 checks passed
@bors bors bot deleted the ck/up_cts branch October 4, 2023 23:17
This was referenced Oct 6, 2023
Closed
Merged
bors bot added a commit that referenced this pull request Oct 6, 2023
@bors @charleskawczynski
Merge #2204
50d2405 
2204: Remove temporary time stepper components r=charleskawczynski a=charleskawczynski

This PR removes the old temporary time stepper components. I forgot to remove this in #2187.

Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
bors bot added a commit that referenced this pull request Oct 7, 2023
@bors @charleskawczynski
Merge #2204
e12f5a4 
2204: Remove temporary time stepper components r=charleskawczynski a=charleskawczynski

This PR removes the old temporary time stepper components. I forgot to remove this in #2187.

Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonbyrne simonbyrne Awaiting requested review from simonbyrne

Assignees
No one assigned
Labels
Performance
Projects
None yet
Milestone
O1.1.2: 6 SYPD for moist Held Suarez
Development

Successfully merging this pull request may close these issues.

Only call set_precomputed_quantities! once in the implict stage
1 participant
@charleskawczynski