Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FDScheme in SurfaceFluxes #2231

Closed
wants to merge 1 commit into from
Closed

Use FDScheme in SurfaceFluxes #2231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/surface_conditions/surface_conditions.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ surface_state(
# conditions, but without throwing an error during the computation of
# precomputed quantities for diagnostic EDMF due to uninitialized surface
# conditions.
# TODO: Refactor the surface conditions API to avoid needing to do this.
# TODO: Refactor the surface conditions API to avoid needing to do this.
function set_dummy_surface_conditions!(p)
(; sfc_conditions, params, atmos) = p
FT = eltype(params)
Expand Down Expand Up @@ -168,7 +168,7 @@ function surface_state_to_conditions(
coordinates isa Geometry.LatLongPoint
)
if atmos.sfc_temperature isa ZonallyAsymmetricSST
#Assume a surface temperature that varies with both longitude and latitude, Neale and Hoskins, 2021
#Assume a surface temperature that varies with both longitude and latitude, Neale and Hoskins, 2021
T =
(
(-60 < coordinates.lat < 60) ?
Expand Down Expand Up @@ -352,7 +352,7 @@ function surface_state_to_conditions(
end

return atmos_surface_conditions(
SF.surface_conditions(surface_params, inputs),
SF.surface_conditions(surface_params, inputs, SF.FDScheme()),
ts,
surface_local_geometry,
atmos,
Expand Down
6 changes: 5 additions & 1 deletion test/coupler_compatibility.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,11 @@ end
FT(gustiness),
FT(beta),
)
return SF.surface_conditions(surface_params, surface_inputs)
return SF.surface_conditions(
surface_params,
surface_inputs,
SF.FDScheme(),
)
end

# Test that set_surface_conditions! can be used to update the surface
Expand Down
Loading