Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EDMFX and rename AdvectiveEDMFX to PrognosticEDMFX #2254

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

szy21
Copy link
Member

@szy21 szy21 commented Oct 19, 2023

Purpose

Goodbye EDMFX :)

Closes #2250

To-do

  • Add an example for new diagnostics package for prognostic edmf

Content


  • I have read and checked the items on the review checklist.

@szy21 szy21 marked this pull request as ready for review October 19, 2023 03:35
@szy21 szy21 requested a review from trontrytel October 19, 2023 03:36
@szy21
Copy link
Member Author

szy21 commented Oct 19, 2023

Do we want to remove the specific_sgs function here, and all the functions in the same file that only used by EDMFX?

@szy21 szy21 force-pushed the zs/remove_flux_edmf branch 2 times, most recently from 9531cf4 to b4747b7 Compare October 19, 2023 18:33
@trontrytel
Copy link
Member

Thank you!

@trontrytel
Copy link
Member

Do we want to remove the specific_sgs function here, and all the functions in the same file that only used by EDMFX?

I vote to remove unused code. Unless you think we might need it again soon?

@szy21
Copy link
Member Author

szy21 commented Oct 20, 2023

Do we want to remove the specific_sgs function here, and all the functions in the same file that only used by EDMFX?

I vote to remove unused code. Unless you think we might need it again soon?

They are already removed:)

@szy21 szy21 force-pushed the zs/remove_flux_edmf branch 2 times, most recently from 3636a79 to f3bfdf8 Compare October 20, 2023 02:42
@szy21 szy21 force-pushed the zs/remove_flux_edmf branch from f3bfdf8 to d037d95 Compare October 20, 2023 04:04
@szy21
Copy link
Member Author

szy21 commented Oct 20, 2023

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 20, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 6bee1ae into main Oct 20, 2023
6 checks passed
@bors bors bot deleted the zs/remove_flux_edmf branch October 20, 2023 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove EDMFX and rename AdvectiveEDMFX
2 participants