Update config and initialization code for DYAMOND configuration #2292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szy21
approved these changes
Oct 25, 2023
Use Float32 for DYAMOND configuration. This helps with kernel metadata size issues. Reduce h_elems to 30. This helps with the memory footprint on the A100 GPU. Compute pressure2ozone interpolation during initialization on the CPU for GPU runs. These temporary changes will help continue finding and debugging potential downstream issues on a single GPU process while fixing known memory footprint and efficiency issues in parallel. The changes can be reverted once appropriate fixes are merged.
sriharshakandala
force-pushed
the
sk/update_dyamond
branch
from
e5a45f6 to
10bba68
Compare
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR makes the following temporary changes:
h_elemsto 30. This helps with the memory footprint on the A100 GPU.pressure2ozoneinterpolation during initialization on the CPU for GPU runs.These temporary changes will help continue finding and debugging potential downstream issues on a single GPU process while fixing known memory footprint and efficiency issues in parallel. The changes can be reverted once appropriate fixes are merged.