Turn cache into struct #2296
Merged
Turn cache into struct #2296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sbozzolo
force-pushed
the
gb/cache_struct
branch
5 times, most recently
from
ca0d9f7 to
53b1d5b
Compare
Merged
Sbozzolo
force-pushed
the
gb/cache_struct
branch
2 times, most recently
from
d208f54 to
ef41092
Compare
Sbozzolo
force-pushed
the
gb/cache_struct
branch
4 times, most recently
from
9179923 to
edd92cc
Compare
|
For some reason, this PR slows down compilation time a lot: |
Sbozzolo
force-pushed
the
gb/cache_struct
branch
from
edd92cc to
3e60242
Compare
|
Found an incantation that is more reasonable, still a little bit slower than without struct (but part of it is probably just the |
Sbozzolo
force-pushed
the
gb/cache_struct
branch
from
3e60242 to
62f6265
Compare
Sbozzolo
force-pushed
the
gb/cache_struct
branch
from
62f6265 to
1d70907
Compare
sriharshakandala
approved these changes
Nov 27, 2023
Sbozzolo
force-pushed
the
gb/cache_struct
branch
from
1d70907 to
804c579
Compare
Sbozzolo
force-pushed
the
gb/cache_struct
branch
from
804c579 to
3a43145
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2217
To be merged after #2287