Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete old TC params struct #2302

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Delete old TC params struct #2302

merged 1 commit into from
Oct 28, 2023

Conversation

trontrytel
Copy link
Member

This PR:

  • Deletes the old EDMF parameter struct
  • Creates a new parameter struct for TurbulenceConvectionParameters parameters. This struct is flat and does not store any thermodynamics or microphysics parameters.
  • Moves all the EDMF relevant parameters out of ClimaAtmosParameters and into TurbulenceConvectionParameters

@szy21 - could you double check if I moved all the edmf parameters?
@nefrathenrici - does that look reasonable?

@trontrytel trontrytel self-assigned this Oct 27, 2023
nefrathenrici
nefrathenrici approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@nefrathenrici nefrathenrici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It seems like some TC fragments are still in the docs.

src/parameters/Parameters.jl Outdated Show resolved Hide resolved
src/parameters/Parameters.jl Show resolved Hide resolved
szy21
szy21 approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@szy21 szy21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/parameters/Parameters.jl Outdated Show resolved Hide resolved
src/parameters/Parameters.jl Show resolved Hide resolved
@sriharshakandala
Copy link
Member

sriharshakandala commented Oct 27, 2023 •
edited
Loading

Please fix docs issues, rebase and squash commits (as needed). Thanks.

@trontrytel trontrytel marked this pull request as ready for review October 27, 2023 22:28
@trontrytel
Copy link
Member Author

bors r+

@bors bors bot merged commit a01efa2 into main Oct 28, 2023
6 checks passed
@bors bors bot deleted the aj/tc_parameters branch October 28, 2023 00:20
@bors
Copy link
Contributor

bors bot commented Oct 28, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nefrathenrici nefrathenrici nefrathenrici approved these changes

@sriharshakandala sriharshakandala sriharshakandala approved these changes

@szy21 szy21 szy21 approved these changes

Assignees

@trontrytel trontrytel

Labels
ClimaParameters 🎛️ EDMF 🌪️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trontrytel @sriharshakandala @szy21 @nefrathenrici