Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix strain rate norm in edmf closures #2308

Merged
merged 1 commit into from
Oct 29, 2023
Merged

fix strain rate norm in edmf closures #2308

merged 1 commit into from
Oct 29, 2023

Conversation

szy21
Copy link
Member

@szy21 szy21 commented Oct 29, 2023

Purpose

We miss a factor of 2 in some closures when changing the calculation of shear^2 (now strain_rate_norm), as the two variables differ by ~ a factor of 2.

To-do

Content


  • I have read and checked the items on the review checklist.

@szy21
Copy link
Member Author

szy21 commented Oct 29, 2023

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 29, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 13dd164 into main Oct 29, 2023
8 checks passed
@bors bors bot deleted the zs/hotfix branch October 29, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant