change edmfx sgs mass flux to advect a*tracer #2337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trontrytel
reviewed
Nov 7, 2023
trontrytel
approved these changes
Nov 7, 2023
szy21
force-pushed
the
zs/sgsflux_numerics
branch
from
2310c2e to
93d4a77
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Also adds an option for the numerical scheme for edmfx sgs mass flux. (Note: This PR is only changing the numerics of sgs mass flux. I will have another PR soon that adds a divergence term in GeneralizedDetrainment, adds a few more cases, and maybe changes the default detrainment for all the cases.)
Closes #2335
To-do
Content