use MSE as a prognostic variable for prognostic edmf #2348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szy21
force-pushed
the
zs/progedmf_mse
branch
from
75ee02b to
4330f55
Compare
szy21
commented
Nov 10, 2023
szy21
commented
Nov 10, 2023
szy21
force-pushed
the
zs/progedmf_mse
branch
3 times, most recently
from
ed63a89 to
9f6f111
Compare
|
I removed draft and environment h_tot from the cache. |
szy21
force-pushed
the
zs/progedmf_mse
branch
from
9f6f111 to
3e6191b
Compare
trontrytel
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Change subdomain prognostic variable from h_tot to MSE. I think this is mostly ready. One thing I want to check is whether we can remove some caches (e.g. only save mse and calculate h_tot on the fly). I may also need to fix allocations for some cases.
Closes #2251
To-do
Content