Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove some regression tests #2351

Merged
merged 1 commit into from
Nov 10, 2023
Merged

remove some regression tests #2351

merged 1 commit into from
Nov 10, 2023

Conversation

szy21
Copy link
Member

@szy21 szy21 commented Nov 9, 2023

Purpose

Also comments out the SSP+zalesak job

To-do

Content

  • I have read and checked the items on the review checklist.

@szy21 szy21 added the Launch Buildkite Add to launch buildkite run label Nov 9, 2023
@szy21 szy21 enabled auto-merge November 10, 2023 00:08
@Sbozzolo
Copy link
Member

Sbozzolo commented Nov 10, 2023 •
edited
Loading

What's the test test_env testing?

The gravity wave tests look like unit tests, can we move them out of buildkite and into the julia Test system? I guess we have to look at the plots.

@szy21
Copy link
Member Author

szy21 commented Nov 10, 2023

What's the test test_env testing?

I don't know about this test. Maybe @charleskawczynski knows?

@szy21 szy21 added this pull request to the merge queue Nov 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 10, 2023
@szy21 szy21 added this pull request to the merge queue Nov 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 10, 2023
@szy21 szy21 added this pull request to the merge queue Nov 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 10, 2023
@szy21 szy21 added this pull request to the merge queue Nov 10, 2023
Merged via the queue into main with commit e64ca3c Nov 10, 2023
10 checks passed
@szy21 szy21 deleted the zs/cleanup_ci branch November 10, 2023 05:58
@charleskawczynski
Copy link
Member

Sorry I'm late to this, test_env is the only buildkite job that launches julia with julia --project=test, which re-resolves the environment and tests ClimaAtmos with the latest versions (which is why that job is marked as soft_fail: true). It was my way to get a bit of a look-ahead to see what things coming down the pipeline were failing so that I could fix problems before people realized that they were coming.

@charleskawczynski
Copy link
Member

(cc @szy21, @Sbozzolo, @sriharshakandala)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Launch Buildkite Add to launch buildkite run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@szy21 @Sbozzolo @charleskawczynski