Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instantaneous zenith angle function #2358

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

sriharshakandala
Copy link
Member

@sriharshakandala sriharshakandala commented Nov 13, 2023

Purpose

Update instantaneous zenith angle function to use fixed orbital parameters.


  • I have read and checked the items on the review checklist.

@sriharshakandala
Copy link
Member Author

src/callbacks/callbacks.jl Show resolved Hide resolved
@sriharshakandala sriharshakandala added the Launch Buildkite Add to launch buildkite run label Nov 13, 2023
@sriharshakandala sriharshakandala force-pushed the sk/update_inst_zenith_ang branch 2 times, most recently from 3661ea4 to d134931 Compare November 14, 2023 06:10
@sriharshakandala sriharshakandala added Launch Buildkite Add to launch buildkite run and removed Launch Buildkite Add to launch buildkite run labels Nov 14, 2023
@sriharshakandala sriharshakandala force-pushed the sk/update_inst_zenith_ang branch from d134931 to df6e0f9 Compare November 14, 2023 07:09
@sriharshakandala sriharshakandala added Launch Buildkite Add to launch buildkite run and removed Launch Buildkite Add to launch buildkite run labels Nov 14, 2023
@sriharshakandala sriharshakandala force-pushed the sk/update_inst_zenith_ang branch from df6e0f9 to 3c730ef Compare November 14, 2023 08:08
@sriharshakandala sriharshakandala added the Launch Buildkite Add to launch buildkite run label Nov 14, 2023
@sriharshakandala
Copy link
Member Author

These seems to be internal Float32 to Float64 conversions in the RRTMGP interface code! This needs to be fixed!

@sriharshakandala sriharshakandala force-pushed the sk/update_inst_zenith_ang branch from 3c730ef to 3b9702d Compare November 14, 2023 17:08
@sriharshakandala sriharshakandala removed the Launch Buildkite Add to launch buildkite run label Nov 14, 2023
@sriharshakandala sriharshakandala force-pushed the sk/update_inst_zenith_ang branch from 27b95a3 to a50e3cb Compare November 14, 2023 17:10
@sriharshakandala sriharshakandala added the Launch Buildkite Add to launch buildkite run label Nov 14, 2023
@sriharshakandala sriharshakandala force-pushed the sk/update_inst_zenith_ang branch 2 times, most recently from f65e27e to 53c66b9 Compare November 20, 2023 18:19
@sriharshakandala sriharshakandala force-pushed the sk/update_inst_zenith_ang branch from d4912f5 to c6481da Compare November 20, 2023 22:05
@sriharshakandala sriharshakandala added this pull request to the merge queue Nov 21, 2023
Merged via the queue into main with commit 765bbda Nov 21, 2023
9 of 10 checks passed
@sriharshakandala sriharshakandala deleted the sk/update_inst_zenith_ang branch November 21, 2023 01:09
Sbozzolo pushed a commit that referenced this pull request Nov 21, 2023
Update instantaneous zenith angle function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Launch Buildkite Add to launch buildkite run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants