Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds an implicit solver for vertical diffusion, which will be extended to support diagnostic EDMF in a followup PR.
Content
0.11.1
, which gives us access to the newApproximateBlockArrowheadIterativeSolve
algorithm, and update all of theManifest.toml
files.implicit_diffusion
, which determines whether to include vertical diffusion in the implicit tendency (and whether to include its derivative in the Jacobian). The current default value isfalse
, but we will change this totrue
after further testing.BlockArrowheadSolve
with anApproximateBlockArrowheadIterativeSolve
whenimplicit_diffusion
istrue
.sphere_baroclinic_wave_rhoe_equilmoist_impvdiff
to the pipeline. This is a copy ofsphere_baroclinic_wave_rhoe_equilmoist_expvdiff
, but withimplicit_diffusion
set totrue
anddt
increased to400secs
. In order for the simulation to produce reasonable results, the value ofmax_newton_iters_ode
needs to be increased to 2. This example currently takes a while to compile (almost half an hour on the cluster), and it prints a long compiler warning about type inference. It should be possible to fix that with the changes in Fix implicit solver compilation issues ClimaCore.jl#1506, which I'll wrap up after we have some preliminary results with diagnostic EDMF.dt
for thesphere_baroclinic_wave_rhoe_equilmoist_expvdiff
example to20secs
because using40secs
or30secs
causes the simulation to crash whent_end
is set to6days
. Decreaset_end
to6hours
so that this example does not slow down CI.