Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make initial conditions independent of the parameter struct #2405

Closed
wants to merge 3 commits into from

Conversation

nefrathenrici
Copy link
Member

Purpose

We want to slowly decouple the parameter struct from function calls and pass parameter values individually or at least more compactly. Initial conditions is a good initial example of this.

To-do

Apply changes to EDMF initial conditions

Content

  • Change LocalState to include grav and thermo_params instead of params
  • Remove most InitialConditions structs
  • Change InitialConditions functions to take in only the necessary parameters
  • Change get_initial_conditions to match the new structure

  • I have read and checked the items on the review checklist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant