Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARS no limiter FCT to longrun pipeline #2577

Closed
wants to merge 1 commit into from

Conversation

charleskawczynski
Copy link
Member

Copy link
Member

@szy21 szy21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the toml file following this line:

toml: [toml/longrun_hs_rhoe_equil_55km_nz63_0M.toml]

@szy21
Copy link
Member

szy21 commented Jan 26, 2024

Also, it seems you are not using GPU? If so, maybe just put it in ./buildkite/longruns/pipeline.yml?

Copy link
Member

@szy21 szy21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge after making the changes.

@szy21
Copy link
Member

szy21 commented Jan 26, 2024

Oh, one more thing. If you want plots, add the job_id to ci_plots.jl.

@charleskawczynski
Copy link
Member Author

Also, it seems you are not using GPU? If so, maybe just put it in ./buildkite/longruns/pipeline.yml?

Right, do you think it should be a CPU or GPU job?

@szy21
Copy link
Member

szy21 commented Jan 26, 2024

Let's add the toml file following this line:

toml: [toml/longrun_hs_rhoe_equil_55km_nz63_0M.toml]

What is this doing again?

This is adding the correct parameters for the rayleigh sponge.

@szy21
Copy link
Member

szy21 commented Jan 26, 2024

Also, it seems you are not using GPU? If so, maybe just put it in ./buildkite/longruns/pipeline.yml?

Right, do you think it should be a CPU or GPU job?

I was thinking using central cluster for this job (which is what longrun/pipeline.yml uses), as it may still change. We have been using CPUs for that pipeline. But if we can use both central CPU and GPU in the same pipeline, I think GPU is good too.
Basically I just want to keep longrun_gpu/pipeline.yml short as it is using the eight clima GPUs, and there are already seven jobs (I may move some out later).

@charleskawczynski
Copy link
Member Author

I was thinking using central cluster for this job (which is what longrun/pipeline.yml uses), as it may still change. We have been using CPUs for that pipeline. But if we can use both central CPU and GPU in the same pipeline, I think GPU is good too. Basically I just want to keep longrun_gpu/pipeline.yml short as it is using the eight clima GPUs, and there are already seven jobs (I may move some out later).

I'll leave it as CPU for now, but we can change it later if it seems needed.

@szy21
Copy link
Member

szy21 commented Jan 26, 2024

I was thinking using central cluster for this job (which is what longrun/pipeline.yml uses), as it may still change. We have been using CPUs for that pipeline. But if we can use both central CPU and GPU in the same pipeline, I think GPU is good too. Basically I just want to keep longrun_gpu/pipeline.yml short as it is using the eight clima GPUs, and there are already seven jobs (I may move some out later).

I'll leave it as CPU for now, but we can change it later if it seems needed.

Sounds good. It seems you are using only one CPU. It will be very slow. Is that intended?

@charleskawczynski
Copy link
Member Author

Sounds good. It seems you are using only one CPU. It will be very slow. Is that intended?

I didn't know that, I thought all of the other jobs in longrun/pipeline.yml were also using CPU. I'm happy to switch it to a gpu job.

@szy21
Copy link
Member

szy21 commented Jan 26, 2024

Sounds good. It seems you are using only one CPU. It will be very slow. Is that intended?

I didn't know that, I thought all of the other jobs in longrun/pipeline.yml were also using CPU. I'm happy to switch it to a gpu job.

Yes, but they are using multiple cpus. I think you need to specify slurm_ntasks and add srun before julia?

@szy21
Copy link
Member

szy21 commented Aug 15, 2024

Should we close this? We are using SSPKnoth for most simulations now.

@charleskawczynski
Copy link
Member Author

Should we close this? We are using SSPKnoth for most simulations now.

Fine by me.

@charleskawczynski charleskawczynski deleted the ck/ARS_nolim_FCT_lr branch August 15, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants