Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tracer vert adv always explicit #2580

Merged
merged 1 commit into from
Feb 3, 2024
Merged

Make tracer vert adv always explicit #2580

merged 1 commit into from
Feb 3, 2024

Conversation

charleskawczynski
Copy link
Member

Closes #2510. @dennisYatunin, I think you meant to include q_liq/q_ice to be non-passive tracers, as I believe they would play a role in the dynamics for non-equilibrium cases, so I left those where they are. I didn't see any other tracers that needed to be moved in update_implicit_equation_jacobian!, but maybe @dennisYatunin can double check my work.

@dennisYatunin
Copy link
Member

Although q_liq and q_ice play a role in the dynamics, their contribution to the thermodynamic state is negligible because they are several orders of magnitude smaller than q_tot. So, we are ignoring their contribution to the pressure gradient, which means that they do not play a role in the creation of fast waves. This means that we can treat them explicitly.

The changes I'm currently seeing move the advection tendencies for all tracers, including q_tot. The advection of q_tot must remain in the implicit tendency, as it plays a role in the creation of fast waves.

Also, the Jacobian needs to be updated. All blocks that correspond to the advection of passive tracers (this currently includes q_liq, q_ice, q_rai, and q_sno) should be removed. For example, the available_tracer_names in the advection_blocks should be replaced with ρq_tot_if_available in the ImplicitEquationJacobian constructor.

@charleskawczynski
Copy link
Member Author

Alright, @dennisYatunin, I've updated based on your comments. How does this look?

@dennisYatunin
Copy link
Member

dennisYatunin commented Jan 27, 2024

Thanks, @charleskawczynski! I've fixed the remaining issues in this PR, and everything is now working as expected. However, the water budget conservation check is failing for the 1-moment microphysics test in CI. This is unfortunate, but it makes sense that we've introduced some additional error by making the advection of rain and snow at grid-mean velocity explicit. @szy21 and @trontrytel, we should discuss this result next week. If this change is not necessary, we might want to avoid it.

@dennisYatunin dennisYatunin changed the title Make tracer vert adv always explicit CD2 Make tracer vert adv always explicit Jan 27, 2024
@dennisYatunin dennisYatunin added this pull request to the merge queue Feb 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 3, 2024
@dennisYatunin dennisYatunin added this pull request to the merge queue Feb 3, 2024
Merged via the queue into main with commit a415172 Feb 3, 2024
9 of 10 checks passed
@dennisYatunin dennisYatunin deleted the ck/2510 branch February 3, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update IMEX splitting of vertical advection
3 participants