Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new RRTMGP interface #2603

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Update to new RRTMGP interface #2603

merged 2 commits into from
Feb 1, 2024

Conversation

nefrathenrici
Copy link
Member

@nefrathenrici nefrathenrici commented Jan 29, 2024

Update to RRTMGP 0.11.0

Content

  • Change VMR indices
  • Remove random_lw and random_sw from RRTMGPModel
  • Change all instances of solar_zenith_angle to cos_zenith
  • Separate the PADE and default lookup tables
  • Change update_net_fluxes! to use face_sw_flux_up - face_sw_flux_dn instead of face_sw_flux since it is not being set correctly.

Job IDs diagnostic_edmfx_aquaplanet and sphere_aquaplanet_rhoe_equilmoist_allsky_gw_raw_zonallyasymmetric have MSE changes, but @szy21 checked the plots (thank you!).

May break coupler compability, since RRTMGPI is changing.

@nefrathenrici nefrathenrici force-pushed the ne/up_rrtmgp branch 5 times, most recently from 8dd78bc to bc50b53 Compare January 31, 2024 23:31
@nefrathenrici nefrathenrici added this pull request to the merge queue Feb 1, 2024
Merged via the queue into main with commit 6e209f7 Feb 1, 2024
9 of 10 checks passed
@nefrathenrici nefrathenrici deleted the ne/up_rrtmgp branch February 1, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants