Use t_end to determine output frequency #2605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sbozzolo
force-pushed
the
gb/diagnostics_frequency
branch
from
b1cd9d9 to
926459e
Compare
|
This will still cause issues for the current longrun, as they are less than a year with daily output. I will get back to you with a better logic later this afternoon. |
|
How about: Is this too complicated? |
Sbozzolo
force-pushed
the
gb/diagnostics_frequency
branch
from
926459e to
9497f90
Compare
No, easy peasy |
szy21
reviewed
Jan 30, 2024
szy21
reviewed
Jan 30, 2024
szy21
reviewed
Jan 30, 2024
szy21
reviewed
Jan 30, 2024
1 task
Sbozzolo
force-pushed
the
gb/diagnostics_frequency
branch
15 times, most recently
from
b416a11 to
c646272
Compare
|
Just realized that some of the longruns will fail because their output changed. |
Sbozzolo
force-pushed
the
gb/diagnostics_frequency
branch
8 times, most recently
from
1810fe5 to
e7e4acb
Compare
The logic is as follows: If `t_end < 1 day` take hourly means, if `t_end < 30 days` take daily means, if `t_end < 120 days` take means over ten days, If `t_end >= 120 year` take monthly means.
Sbozzolo
force-pushed
the
gb/diagnostics_frequency
branch
from
e7e4acb to
c693763
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic is as follows:
If
t_end < 1 daytake hourly means,if
t_end < 1 yeartake daily means,If
t_end >= 1 yeartake monthly means.