-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
overwrite duplicate diagnostics #2713
Conversation
Maybe print out more information on what was there before overwriting? |
Do you want me to also show what it's getting overwritten with? |
b6f057e
to
d515f69
Compare
No, we assume that users will know what they called. |
Okay! I updated the warning message so it will print something like
|
73bce11
to
e014e55
Compare
a0302cb
to
d140249
Compare
d140249
to
de58d31
Compare
Purpose
Instead of raising an error when a user tries to add a diagnostic that already exists, this PR warns the user and overwrites the existing diagnostic with the new entry.
closes #2709