Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies, switch to ClimaParams #2759

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Update dependencies, switch to ClimaParams #2759

merged 1 commit into from
Mar 12, 2024

Conversation

nefrathenrici
Copy link
Member

@nefrathenrici nefrathenrici commented Mar 5, 2024

Compat changes:

  • Adapt 3.7 -> 4
  • CLIMAParameters 0.9 -> ClimaParams 0.10
  • CloudMicrophysics =0.17 -> 0.18
  • Insolation =0.9.1 -> 0.9.2
  • RRTMGP 0.12 -> 0.13.1
  • SurfaceFluxes 0.9 -> 0.11
  • Thermodynamics =0.12.3 -> 0.12.4
  • I tried to free NCDatasets, but the diagnostics perf job doubled its allocations

Other changes

  • RRTMGPInterface updated
  • Manifests updated to 1.10.2
  • All instances of CLIMAParameters changes to ClimaParams
  • Flame GPU job allocations lowered by from 4.3e6 to 1.6e6, other allocation counts reformatted for readability

@nefrathenrici nefrathenrici marked this pull request as draft March 5, 2024 19:40
@charleskawczynski
Copy link
Member

Let’s rebase this after #2723

@nefrathenrici nefrathenrici force-pushed the ne/up_deps branch 2 times, most recently from ff57790 to e14630a Compare March 6, 2024 22:28
@nefrathenrici nefrathenrici force-pushed the ne/up_deps branch 3 times, most recently from 8bb958f to 01387cc Compare March 8, 2024 18:37
@nefrathenrici nefrathenrici marked this pull request as ready for review March 11, 2024 22:51
@szy21
Copy link
Member

szy21 commented Mar 11, 2024

We should be able to remove the zenith angle check with the latest RRTMGP release. Removing it will change MSE though, so up to you whether you want to do it in this PR.

@nefrathenrici
Copy link
Member Author

@szy21 Thank you for mentioning it! I can do it in the next PR, this is changing a lot of packages but doesn't have simulation output changes.

@nefrathenrici nefrathenrici requested a review from szy21 March 11, 2024 23:27
Copy link
Member

@szy21 szy21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nefrathenrici nefrathenrici added this pull request to the merge queue Mar 12, 2024
Merged via the queue into main with commit 7ab4dbb Mar 12, 2024
11 checks passed
@nefrathenrici nefrathenrici deleted the ne/up_deps branch March 12, 2024 18:27
@Sbozzolo
Copy link
Member

If you can reproduce the problem with NCDatasets we should open an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants